Bug 162273 - [patch] bsd.commands.mk recommends incorrect usage of sudo
Summary: [patch] bsd.commands.mk recommends incorrect usage of sudo
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Chris Rees
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-03 18:40 UTC by Chris Rees
Modified: 2011-12-23 16:33 UTC (History)
0 users

See Also:

Attachments
bsd.commands.mk-su_cmd.diff (622 bytes, patch)
2011-11-03 18:40 UTC, Chris Rees 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rees freebsd_committer freebsd_triage 2011-11-03 18:40:05 UTC 
	Using su -c is not synonymous with sudo sh -c ; the former preserves the environment, while the latter does not.  This bites one when running make install as non-root for example; any make vars set on command line are lost.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-11-03 18:40:14 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->portmgr

bsd.commands.mk is portmgr territory (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2011-12-23 16:19:48 UTC 
crees       2011-12-23 16:19:31 UTC

  FreeBSD ports repository

  Modified files:
    Mk                   bsd.commands.mk 
  Log:
  Correct comment advising how to use sudo as SU_CMD; doesn't work unless
  environment is preserved
  
  PR:             ports/162273
  Submitted by:   crees
  Approved by:    portmgr (linimon)
  
  Revision  Changes    Path
  1.9       +2 -2      ports/Mk/bsd.commands.mk
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Chris Rees freebsd_committer freebsd_triage 2011-12-23 16:32:50 UTC 
Responsible Changed
From-To: portmgr->crees

I'll take it.
Comment 4 Chris Rees freebsd_committer freebsd_triage 2011-12-23 16:33:05 UTC 
State Changed
From-To: open->closed

Committed.