Parsers generated by the YACC tool in caml-light use insecure temporary files. The build process also uses temporary files in a permissive way. The attached patch is believed to fix these two issues. This PR and the attached patch are base on: http://gnats.netbsd.org/45558 I wish to warmly thank Eitan Adler who sent me this u seful reference.
Class Changed From-To: maintainer-update->change-request Fix category (submitter is not maintainer) (via the GNATS Auto Assign Tool)
Maintainer of lang/caml-light, Please note that PR ports/162577 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/162577 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Dear FreeBSD Committers, Edwin Groothuis wrote: > Maintainer of lang/caml-light, > > Please note that PR ports/162577 has just been submitted. > > If it contains a patch for an upgrade, an enhancement or a bug fix > you agree on, reply to this email stating that you approve the patch > and a committer will take care of it. I approve the patch. BTW I am also emmitter of the patch, and I am pretty sure I selected `maintainer-update` where appropriate. Did I overlook something? Best regards, Michael
Responsible Changed From-To: freebsd-ports-bugs->miwi I'll take it.
Probably edwin's auto-assigner was confused by the characters in your email address; take a look at the web view. Chris
State Changed From-To: feedback->open Maintainer has approved.
State Changed From-To: open->feedback Patch failed Hmm... Looks like a unified diff to me... The text leading up to this was: -------------------------- |diff --git a/files/patch-src_launch_Makefile |b/files/patch-src_launch_Makefile |index 38b39aa..afba4c5 100644 |--- a/files/patch-src_launch_Makefile |+++ b/files/patch-src_launch_Makefile -------------------------- File to patch: files/patch-src_launch_Makefile Patching file files/patch-src_launch_Makefile using Plan A... patch: **** malformed patch at line 34: diff --git a/files/patch-src_yacc_main.c b/files/patch-src_yacc_main.c
Here is a new patch. For the record, the old patch was produced with: git diff --relative caml-light-0.75_3 caml-light-0.75_4 \ > caml-light.patch Header data in the resulting patch contains file names like /a/... (old file) and /b/... (new file). This puzzles the `patch` programs that needs the `-p 1` to cope guess the right names out of this header data. To produce a clean patch, like the one attached, we need to use `--no-prefix` option of the git-diff subcommand.
State Changed From-To: feedback->open Feedback received
miwi 2012-01-29 13:11:51 UTC FreeBSD ports repository Modified files: lang/caml-light Makefile lang/caml-light/files patch-src_launch_Makefile Added files: lang/caml-light/files patch-src_yacc_main.c Log: - Fix Build PR: 162577 Submitted by: maintainer Revision Changes Path 1.21 +1 -1 ports/lang/caml-light/Makefile 1.2 +15 -9 ports/lang/caml-light/files/patch-src_launch_Makefile 1.1 +81 -0 ports/lang/caml-light/files/patch-src_yacc_main.c (new) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed. Thanks!