Bug 162671 - [patch] lang/chicken: mark as MAKE_JOBS_SAFE
Summary: [patch] lang/chicken: mark as MAKE_JOBS_SAFE
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Martin Wilke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-19 01:10 UTC by Jan Beich
Modified: 2011-11-25 18:20 UTC (History)
0 users

See Also:


Attachments
multijobs.diff (796 bytes, patch)
2011-11-19 01:10 UTC, Jan Beich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2011-11-19 01:10:06 UTC
shlibs want to link against libchicken.so, so it should be built before them

How-To-Repeat: $ make
$ for f in $(make -V WRKSRC)/*.so; do
  if ! readelf -d $f | grep -q 'NEEDED.*chicken'; then
     echo $f doesn\'t depend on libchicken.so
  fi; done
WRKSRC/libchicken.so doesn't depend on libchicken.so
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-11-19 01:10:14 UTC
Maintainer of lang/chicken,

Please note that PR ports/162671 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/162671

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2011-11-19 01:10:16 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Martin Wilke freebsd_committer freebsd_triage 2011-11-19 07:50:05 UTC
Responsible Changed
From-To: freebsd-ports-bugs->miwi

I'll take it.
Comment 4 Vitaly Magerya 2011-11-19 10:22:33 UTC
I've been pushing a similar patch to the upstream some time ago in
hope that it'll get into the next release, so I wouldn't have to
maintain it in the port, but I wasn't successful.

Anyway, if there is interest in making lang/chicken MAKE_JOBS_SAFE
right now (as opposed to the next release), I propose to commit [1],
while I go and annoy the upstream with this issue once again. Sounds
good?

[1] http://tx97.net/~magv/chicken-jobs-safe.diff
Comment 5 Jan Beich freebsd_committer freebsd_triage 2011-11-19 16:09:59 UTC
Vitaly Magerya <vmagerya@gmail.com> writes:

> Anyway, if there is interest in making lang/chicken MAKE_JOBS_SAFE
> right now (as opposed to the next release), I propose to commit [1],
> while I go and annoy the upstream with this issue once again. Sounds
> good?

I agree either way. It makes checking build issues less annoying as the
port builds faster, e.g. `chicken-install -update-db' hangs during
install on my box when using clang + -O1 (or greater).
Comment 6 Martin Wilke freebsd_committer freebsd_triage 2011-11-25 18:14:15 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!
Comment 7 dfilter service freebsd_committer freebsd_triage 2011-11-25 18:14:17 UTC
miwi        2011-11-25 18:14:08 UTC

  FreeBSD ports repository

  Modified files:
    lang/chicken         Makefile 
  Log:
  - Mark it JOBS_SAFE
  
  PR:             162671
  Submitted by:   Jan Beich <jbeich@tormail.net>
  Approved by:    maintainer
  Feature safe:   yes
  
  Revision  Changes    Path
  1.47      +3 -1      ports/lang/chicken/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"