Bug 162913 - [patch] lang/rexx-wrapper: respect CC/CFLAGS
Summary: [patch] lang/rexx-wrapper: respect CC/CFLAGS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Martin Wilke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-28 05:50 UTC by Jan Beich
Modified: 2012-01-14 19:12 UTC (History)
0 users

See Also:


Attachments
cc.diff (780 bytes, patch)
2011-11-28 05:50 UTC, Jan Beich
no flags Details | Diff
cc.diff (1.09 KB, patch)
2011-11-30 00:30 UTC, Jan Beich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2011-11-28 05:50:24 UTC
Responsible Changed
From-To: freebsd-ports-bugs->miwi

miwi@ wants his PRs (via the GNATS Auto Assign Tool)
Comment 2 Jan Beich freebsd_committer freebsd_triage 2011-11-30 00:30:00 UTC
- do not replace compiler list
- add CC to configur
- remove `@'
Comment 3 Jan Beich freebsd_committer freebsd_triage 2011-12-17 14:41:57 UTC
Unlike the approach committed by dim@ recently my patch does not favor
clang but fixes CC irrespectively of compiler, e.g.

  $ make CC=gcc46 # vanilla Makefile@r1.6
  [...]
  ===>  Building for rexx-wrapper-2.4
  rexx ./rexxwrap.cmd -program=rexxwrapper -rexxfiles=./rexxwrap.cmd  -compiler=gcc46 -interpreter=regina -srcdir=. -compress
  This is Rexx/Wrapper 2.4 - 21 September 2006
  --------------------------------------------
  ************************************************************
  unsupported compiler specified with -compiler= switch; must be one of: gcc clang cc c89 egcs xlc
  ************************************************************
  *** [rexxwrapper] Error code 1
  1 error

  $ make CC=gcc46 # with my patch
  [...]
  ===>  Building for rexx-wrapper-2.4
  rexx ./rexxwrap.cmd -program=rexxwrapper -rexxfiles=./rexxwrap.cmd  -compiler=gcc46 -interpreter=regina -srcdir=. -compress
  This is Rexx/Wrapper 2.4 - 21 September 2006
  --------------------------------------------
  Running configure script...
  creating cache ./config.cache
  updating cache ./config.cache
  creating ./config.status
  creating defined_values
  creating config.h
  Compiling ZLIB modules...compress uncompr deflate inflate adler32 zutil trees inftrees inffast crc32
  Compiling intbuild.c...
  Linking intbuild...
  Running intbuild to produce rexxwrapper.c...
     If you need to dump the original code from the rexxwrapper executable, run:
   rexxwrapper --key=1
  Compiling rexxwrapper.c...
  Compiling getargv0.c...
  Linking rexxwrapper
  Done! rexxwrapper built successfully
Comment 4 Martin Wilke freebsd_committer freebsd_triage 2011-12-18 09:18:37 UTC
State Changed
From-To: open->feedback

can you please resend as attachment thx.
Comment 5 Martin Wilke freebsd_committer freebsd_triage 2012-01-14 19:12:11 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!