In my previous submission (pr=162603) which has been committed, I added -lpng in LDFLAGS to force the use of libpng, as the test in configure was failing. It turned out, thanks to a friend of mine, that there is a problem with bashism in configure (actually in m4/libpng.m4). So I added a patch for configure in files/, and restored LDFLAGS. The fix has been pushed upstream and committed in SVN revision 10694. Fix: Patch attached with submission follows:
Responsible Changed From-To: freebsd-ports-bugs->rene rene@ wants his PRs (via the GNATS Auto Assign Tool)
Maintainer of net-p2p/amule, Please note that PR ports/163182 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/163182 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Barbara <barbara.xxx1975@libero.it> writes: > +- CFLAGS+=" $LIBPNG_CFLAGS" > +- LDFLAGS+=" $LIBPNG_LDFLAGS" > +- LIBS+=" $LIBPNG_LIBS" > ++ CFLAGS="$CFLAGS $LIBPNG_CFLAGS" > ++ LDFLAGS="$LDFLAGS $LIBPNG_LDFLAGS" > ++ LIBS="$LIBS $LIBPNG_LIBS" Why not reuse REINPLACE_CMD in Makefile? Altering configure script in multiple places can be confusing.
> >Why not reuse REINPLACE_CMD in Makefile? Altering configure >script in multiple places can be confusing. > > That's nice. I did not remember about that fact that configure is manipulated in Makefile too.
State Changed From-To: feedback->closed Committed, thanks
rene 2011-12-25 19:03:09 UTC FreeBSD ports repository Modified files: net-p2p/amule Makefile Added files: net-p2p/amule/files patch-configure Log: Fix libpng check in configure script, fixed upstream in r10694. PR: ports/163182 Submitted by: Barbara Approved by: maintainer timeout (swell.k, 14 days) Revision Changes Path 1.51 +3 -2 ports/net-p2p/amule/Makefile 1.1 +15 -0 ports/net-p2p/amule/files/patch-configure (new) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"