Upgrade audacity from 1.3.13 to 1.3.14 Fix: Apply patch Patch attached with submission follows: How-To-Repeat: Apply patch
Responsible Changed From-To: freebsd-ports-bugs->pawel I'll take it.
State Changed From-To: open->feedback Build fails when WITH_DEBUG=true, please see log: http://people.freebsd.org/~pawel/buildlogs/7/audacity-devel-1.3.14.log
Removed debug option now.
Hello, While testing further I added some improvements: - depend on audio/jack otherwise missing dep might happen - make options actually work, setting options to off turns off features, some options need external libraries etc There is still some problems: - setting options MIDI or UNICODE to off results in broken build. Should I remove those options too or maybe you want to fix those? - option TAGLIB seems to be superfluous, I can't find any evidence that audacity binary links to or uses it, maybe I'm missing something here... -- pozdrawiam / with regards Pawe³ Pêkala
Responsible Changed From-To: pawel->eadler I'll take it.
Responsible Changed From-To: eadler->pawel sorry, I took your pr
There isn't any --without-option, only a --with-option, I'm fixing the other options and will post another patch once done. On Sun, Dec 18, 2011 at 11:03 AM, <pawel@freebsd.org> wrote: > Synopsis: Upgrade audio/audacity from 1.3.13 to 1.3.14 > > Responsible-Changed-From-To: freebsd-ports-bugs->pawel > Responsible-Changed-By: pawel > Responsible-Changed-When: Sun Dec 18 19:03:04 UTC 2011 > Responsible-Changed-Why: > I'll take it. > > http://www.freebsd.org/cgi/query-pr.cgi?pr=163278 > _______________________________________________ > freebsd-ports-bugs@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs > To unsubscribe, send any mail to "freebsd-ports-bugs-unsubscribe@freebsd.org"
> There isn't any --without-option, only a --with-option This is simply not true, here's configure output (after my modifications to port) with all options set: Finished configure: LIBVORBIS: using SYSTEM libraries LIBMAD: using SYSTEM libraries LIBSNDFILE: using SYSTEM libraries LIBFLAC: using SYSTEM libraries LIBID3TAG: using SYSTEM libraries LIBSAMPLERATE: disabled LIBRESAMPLE: using LOCAL libraries LIBSBSMS: using LOCAL libraries LIBSOUNDTOUCH: using SYSTEM libraries LIBNYQUIST: using LOCAL libraries LIBVAMP: using LOCAL libraries LIBEXPAT: using SYSTEM libraries LIBTWOLAME: using SYSTEM libraries FFMPEG: using LOCAL libraries PORTSMF: using LOCAL libraries PORTAUDIO: using LOCAL libraries ladspa: enabled audiounits: disabled prefix=3D/usr/local and same output with all options set to off: Finished configure: LIBVORBIS: disabled LIBMAD: disabled LIBSNDFILE: using SYSTEM libraries LIBFLAC: disabled LIBID3TAG: disabled LIBSAMPLERATE: using SYSTEM libraries LIBRESAMPLE: disabled LIBSBSMS: disabled LIBSOUNDTOUCH: disabled LIBNYQUIST: disabled LIBVAMP: disabled LIBEXPAT: using SYSTEM libraries LIBTWOLAME: disabled FFMPEG: disabled PORTSMF: disabled PORTAUDIO: using LOCAL libraries ladspa: disabled audiounits: disabled prefix=3D/usr/local --=20 pozdrawiam / with regards Pawe=B3 P=EAkala
Looks like the configure --help doesn't document it. Still working on fixing the options. 2011/12/25 Pawel Pekala <pawel@freebsd.org>: >> There isn't any --without-option, only a --with-option > > This is simply not true, here's configure output (after my > modifications to port) with all options set: > > Finished configure: > LIBVORBIS: using SYSTEM libraries > LIBMAD: using SYSTEM libraries > LIBSNDFILE: using SYSTEM libraries > LIBFLAC: using SYSTEM libraries > LIBID3TAG: using SYSTEM libraries > LIBSAMPLERATE: disabled > LIBRESAMPLE: using LOCAL libraries > LIBSBSMS: using LOCAL libraries > LIBSOUNDTOUCH: using SYSTEM libraries > LIBNYQUIST: using LOCAL libraries > LIBVAMP: using LOCAL libraries > LIBEXPAT: using SYSTEM libraries > LIBTWOLAME: using SYSTEM libraries > FFMPEG: using LOCAL libraries > PORTSMF: using LOCAL libraries > PORTAUDIO: using LOCAL libraries > ladspa: enabled > audiounits: disabled > prefix=3D/usr/local > > and same output with all options set to off: > > Finished configure: > LIBVORBIS: disabled > LIBMAD: disabled > LIBSNDFILE: using SYSTEM libraries > LIBFLAC: disabled > LIBID3TAG: disabled > LIBSAMPLERATE: using SYSTEM libraries > LIBRESAMPLE: disabled > LIBSBSMS: disabled > LIBSOUNDTOUCH: disabled > LIBNYQUIST: disabled > LIBVAMP: disabled > LIBEXPAT: using SYSTEM libraries > LIBTWOLAME: disabled > FFMPEG: disabled > PORTSMF: disabled > PORTAUDIO: using LOCAL libraries > ladspa: disabled > audiounits: disabled > prefix=3D/usr/local > > -- > pozdrawiam / with regards > Pawe=C5=82 P=C4=99kala
New patch with options fixed.
pawel 2011-12-28 20:50:28 UTC FreeBSD ports repository Modified files: audio/audacity-devel Makefile distinfo pkg-plist Log: - Update to 1.3.14 [1] - Remove DEBUG, MIDI, UNICODE options which cause broken build when set to off [1] - Add dependency on audio/jack - linking to it can't be disabled, this leads to missing dependency when installed - Add INSTALLS_ICONS - Make options actually work, add couple of missing dependencies when options are set to on, disable compiled in features when options are set to off - Fix plist when NOPORTDOCS=true PR: ports/163278 [1] Submitted by: maintainer [1] Revision Changes Path 1.57 +40 -20 ports/audio/audacity-devel/Makefile 1.16 +2 -2 ports/audio/audacity-devel/distinfo 1.18 +10 -4 ports/audio/audacity-devel/pkg-plist _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Committed. Thanks!