Upgrade devel/opengrok to 0.10 - Fixes port such that packages (.tbz) can be built- - Installs to apache-tomcat-6||55||resin/webapps/${PORTAME}.war instead of source.war - Fixes a few portlint issues Fix: Patch attached with submission follows:
Responsible Changed From-To: freebsd-ports-bugs->jgh I'll take this
Can you please try this diff, and let me know what you think? It is customary if an application server is going to expand a file, to list those files and not just install a war file. This is done so it can be cleaned up properly when it is de-installed. I also added some checks to make sure the application server wasn't defined more than once, but only once. I have also accounted for a non-default web.xml file, and not clobber on installation, or de-installation. Additionally, while I was modifying the port, I made the java vendor configurable, and sorted the application servers to match the options order. Thanks for your contribution, and testing! :) Jason -- Jason Helfman | FreeBSD Committer jgh@FreeBSD.org | http://people.freebsd.org/~jgh
I mistakenly dropped NOPORTDOC from pkg-plist. Here is the updated patch. -jgh -- Jason Helfman | FreeBSD Committer jgh@FreeBSD.org | http://people.freebsd.org/~jgh
This patch works great. I think it's perfect, actually, especially since y= ou added the webapps\ files to plist. Should add and remove soundly. -----Original Message----- From: Jason Helfman [mailto:bsd-src@helfman.org] On Behalf Of Jason Helfman Sent: Wednesday, December 21, 2011 5:17 PM To: bug-followup@freebsd.org Cc: Evan Sarmiento Subject: Re: ports/163459: Upgrade devel/opengrok to 0.10 Can you please try this diff, and let me know what you think? It is customary if an application server is going to expand a file, to list= those files and not just install a war file. This is done so it can be cle= aned up properly when it is de-installed. I also added some checks to make sure the application server wasn't defined= more than once, but only once. I have also accounted for a non-default web.xml file, and not clobber on in= stallation, or de-installation. Additionally, while I was modifying the port, I made the java vendor config= urable, and sorted the application servers to match the options order. Thanks for your contribution, and testing! :) Jason --=20 Jason Helfman | FreeBSD Committer jgh@FreeBSD.org | http://people.freebsd.org/~jgh
jgh 2011-12-25 00:20:49 UTC FreeBSD ports repository Modified files: devel/opengrok Makefile distinfo pkg-plist Log: PR: ports/163459 (based on) Submitted by: Evan Sarmiento <esarmiento at wayfair.com> Approved by: crees (mentor) update to 0.10 install expanded war file, so it is properly de-installs add santity checks for application server defines account for non-default web.xml file allow configuration for JAVA_VENDOR mirror application servers checks based on OPTIONS order Revision Changes Path 1.4 +58 -26 ports/devel/opengrok/Makefile 1.4 +2 -2 ports/devel/opengrok/distinfo 1.3 +115 -9 ports/devel/opengrok/pkg-plist _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed, with minor changes. Thanks!