Bug 163564 - [maintainer] [patch] mail/mimedefang fix rc.d script
Summary: [maintainer] [patch] mail/mimedefang fix rc.d script
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Michael Scheidell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-23 15:10 UTC by m.tsatsenko
Modified: 2011-12-28 14:30 UTC (History)
0 users

See Also:


Attachments
file.diff (2.30 KB, patch)
2011-12-23 15:10 UTC, m.tsatsenko
no flags Details | Diff
mime_patch.txt (1.49 KB, text/plain)
2011-12-28 00:12 UTC, Michael Scheidell
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description m.tsatsenko 2011-12-23 15:10:11 UTC
- Force to always wait for daemon shutdown in stop_it func. Otherwise mimedefang may not work if stop/start was made too fast.
Suggested by: Daniel O'Connor <doconnor at gsoft dot com dot au>
- Bump PORTREVISION
Comment 1 Michael Scheidell freebsd_committer freebsd_triage 2011-12-27 15:12:49 UTC
Responsible Changed
From-To: freebsd-ports-bugs->scheidell

I'll take it.
Comment 2 Michael Scheidell 2011-12-28 00:12:44 UTC
I have an alternate Makefile I would like you to consider. (mostly portlint issues),
Moving paragraphs (LICENSE) down so it is in right place (see portlint .abctC)

Make clamav an option knob, and adding in dependency (or ../configure didn't find it and 
ignored it anyway if it wasn't installed first)

So, you can prevent clamav by one of two ways (both work)
#1:  define MIMEDEFANG_DISABLE_CLAMAV
#2, make config and deselect WITH_CLAMAV

Other than that, it compiles and looks fine.

Let me know if this alternate Makefile is ok and I will commit this.

-- 
Michael Scheidell, CTO
SECNAP Network Security Corporation
(561) 999-5000 scheidell@secnap.net
http://www.secnap.com/

______________________________________________________________________
This email has been scanned and certified safe by SpammerTrap(r). 
For Information please see http://www.spammertrap.com/
______________________________________________________________________  
  
Comment 3 m.tsatsenko 2011-12-28 13:19:57 UTC
I agree.
Thanks for your work!
Comment 4 dfilter service freebsd_committer freebsd_triage 2011-12-28 14:26:35 UTC
scheidell    2011-12-28 14:26:17 UTC

  FreeBSD ports repository

  Modified files:
    mail/mimedefang      Makefile 
    mail/mimedefang/files patch-examples__init-script.in 
  Log:
  - Force rc_script to wait on stop to prevent race condition on stop/start combo [1]
  - Private email from Daniel O'Connor <doconnor at gsoft dot com dot au>
  
  PR:             ports/163564 [1]
  Submitted by:   m.tsatsenko@gmail.com
  Approved by:    m.tsatsenko@gmail.com (maintainer), gabor (mentor, implicit)
  
  Revision  Changes    Path
  1.75      +11 -4     ports/mail/mimedefang/Makefile
  1.2       +15 -6     ports/mail/mimedefang/files/patch-examples__init-script.in
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Michael Scheidell freebsd_committer freebsd_triage 2011-12-28 14:26:50 UTC
State Changed
From-To: open->closed

Committed with changes, Thanks.