Due to two issues, the gnome2 interface in vim cannot be selected. The first reason is that WITH_GTK2 is set if nothing else is chosen, but that check looks for WITH_GNOME, instead of WITH_GNOME2 as defined by OPTIONS. The second reason is a conditional in the WITH_GNOME2 logic that I'm not really sure of the reason behind. The conditional only allows the gnome2 interface if WITH_GNOME2 is set to "yes" or "1", though bsd.options.mk sets the variable to "true". The attached patch resolves both these issues. Also, David I can't help but notice that vim hasn't been updated in almost half a year. If this is unintentional due to time constraints, I'd be happy to maintain the port for a while if you'd like. If this is intentional and none of the nearly 300 additional patches have sounded appealing, please forgive any insinuation otherwise.
Responsible Changed From-To: freebsd-ports-bugs->obrien Over to maintainer (via the GNATS Auto Assign Tool)
State Changed From-To: open->closed No response from maintainer in 4.5 months. I'm considering this a maintainer timeout. I've committed the patches in this PR.
adamw 2012-05-28 22:04:54 UTC FreeBSD ports repository Modified files: editors/vim Makefile Log: Fix gnome2 support. Two bugs prevented the GNOME2 config options from being acknowledged. [1] A check was made for WITH_GNOME, instead of WITH_GNOME2 [2] A check explicitly ignored the WITH_GNOME2 option unless that variable was set to "1" or "yes", despite bsd.options.mk specifically setting it to "true" PR: ports/164129 Approved by: maintainer timeout (4.5 months) Revision Changes Path 1.391 +1 -4 ports/editors/vim/Makefile _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"