Bug 164344 - [maintainer patch] astro/merkaartor: Don't use INSTALL_ICONS when Gnome not installed
Summary: [maintainer patch] astro/merkaartor: Don't use INSTALL_ICONS when Gnome not i...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Michael Scheidell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-20 20:30 UTC by Oliver Heesakkers
Modified: 2012-01-21 01:01 UTC (History)
0 users

See Also:

Attachments
file.diff (839 bytes, patch)
2012-01-20 20:30 UTC, Oliver Heesakkers 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Heesakkers 2012-01-20 20:30:12 UTC 
I recently became aware that INSTALL_ICONS is set in this port that I took over. INSTALL_ICONS appears to be a very Gnome-specific instruction to ensure icons appear in Gnome's menu.

Setting INSTALL_ICONS pulls in a lot of Gnome-specific ports that are not necessary for the correct functioning of Merkaartor.

Ofcourse, if you do use Gnome, setting this would be desirable, so I set INSTALL_ICONS if ${LOCALBASE}/bin/gnome-session is present on the system

I don't know why the diff-output touches the boost line, but it doesn't look to hurt either.

How-To-Repeat: Start in an empty FreeBSD environment, start the Merkaartor build and watch it pull in a lot of gnome stuff
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-01-20 20:30:23 UTC 
Class Changed
From-To: sw-bug->maintainer-update

Fix category (submitter is maintainer) (via the GNATS Auto Assign Tool)
Comment 2 Michael Scheidell freebsd_committer freebsd_triage 2012-01-20 22:32:59 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->scheidell

I'll take it
Comment 3 dfilter service freebsd_committer freebsd_triage 2012-01-21 00:47:25 UTC 
scheidell    2012-01-21 00:47:16 UTC

  FreeBSD ports repository

  Modified files:
    astro/merkaartor     Makefile 
  Log:
  - Don't use INSTALL_ICONS when Gnome not installed
  
  PR:             ports/164344
  Approved by:    gabor(mentor, implicit)
  
  Revision  Changes    Path
  1.20      +5 -2      ports/astro/merkaartor/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Michael Scheidell freebsd_committer freebsd_triage 2012-01-21 01:01:06 UTC 
State Changed
From-To: open->closed

Committed, Thanks.