Bug 164567 - [PATCH] Fix port: audio/oss panics on 9+ if sound built into kernel
Summary: [PATCH] Fix port: audio/oss panics on 9+ if sound built into kernel
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Jung-uk Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-28 11:30 UTC by Chris Rees
Modified: 2019-09-20 03:51 UTC (History)
0 users

See Also:

Attachments
patch.txt (2.31 KB, text/plain)
2012-01-28 11:30 UTC, Chris Rees 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rees freebsd_committer freebsd_triage 2012-01-28 11:30:12 UTC 
	On 9+, the kernel objects and panics if make_dev is called on a device name that already exists; coupled with the latest commits to GENERIC that makes sound compiled in by default leaves a stock system vulnerable to panics if oss is installed and started.

	The patch replaces the panic with a warning and aborts the load.

	http://lists.freebsd.org/pipermail/freebsd-multimedia/2011-December/012629.html
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-01-28 11:30:49 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->jkim

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Chris Rees 2012-01-29 20:22:34 UTC 
Oops... somehow regenerated patch had wrong pathnames!

New patch (that works :)

Chris

http://www.bayofrum.net/~crees/patches/oss-dont-clobber-dev.diff
Comment 3 dfilter service freebsd_committer freebsd_triage 2012-01-31 21:03:31 UTC 
jkim        2012-01-31 21:03:22 UTC

  FreeBSD ports repository

  Modified files:
    audio/oss            Makefile 
    audio/oss/files      patch-kernel-OS-FreeBSD-os_freebsd.c 
  Log:
  - Do not allow loading osscore when sound(4) is loaded. [1]
  - Make portlint little happier.
  
  PR:             ports/164567 [1]
  Submitted by:   crees (initial version) [1]
  
  Revision  Changes    Path
  1.45      +3 -2      ports/audio/oss/Makefile
  1.11      +42 -3     ports/audio/oss/files/patch-kernel-OS-FreeBSD-os_freebsd.c
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Jung-uk Kim freebsd_committer freebsd_triage 2012-01-31 21:03:57 UTC 
State Changed
From-To: open->closed

A slightly different version was committed.  Thanks!