Responsible Changed From-To: freebsd-ports-bugs->crees Submitter has GNATS access (via the GNATS Auto Assign Tool)
Maintainer of sysutils/ezjail, Please note that PR ports/164745 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/164745 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Where can I find the mentioned policy? Once we go so far as to provide the default config in $prefix/etc anyway, we should not put the config.dist into $prefix/etc, too, but rather somewhere /usr/share'ish? Also what is wrong with cp's -n switch? ${CP} -np ${PREFIX}/etc/ezjail.conf.sample ${PREFIX}/etc/ezjail.conf might even fit on a single line... similarly @exec cp -np %D/%F %B/ezjail.conf looks much more straight forward... once you accept cryptic %-variables, which I consider a safe way to reduce the number of package maintainers ;) erdgeist
Hi Dirk, On 3 February 2012 22:10, Dirk Engling <erdgeist@erdgeist.org> wrote: > > Where can I find the mentioned policy? Once we go so far as to provide > the default config in $prefix/etc anyway, we should not put the > config.dist into $prefix/etc, too, but rather somewhere /usr/share'ish? Not a bad idea, but the standard procedure is documented in the Porter's Handbook [1] and is the way it is done in almost all ports. > Also what is wrong with cp's -n switch? > > ${CP} -np ${PREFIX}/etc/ezjail.conf.sample ${PREFIX}/etc/ezjail.conf > > might even fit on a single line... similarly > > @exec cp -np %D/%F %B/ezjail.conf > > looks much more straight forward... once you accept cryptic %-variables, > which I consider a safe way to reduce the number of package maintainers ;) Yes, % variables are a quirk of pkg_create and are in the manpage for it-- I know they're weird :) The -n option is non-standard according to the cp manpage, and possibly it's never occurred to anyone to use that. Chris [1] http://www.freebsd.org/doc/en/books/porters-handbook/book.html#PLIST-CONFIG
On 03.02.12 23:32, Chris Rees wrote: > Not a bad idea, but the standard procedure is documented in the > Porter's Handbook [1] and is the way it is done in almost all ports. Well, so I am not sure how to continue? Open a maintainer update PR with some patch? > The -n option is non-standard according to the cp manpage, and > possibly it's never occurred to anyone to use that. non-standard meaning that other BSDs that could benefit from the (Free)BSD ports do not have that? So is it a no-go to use even in very BSD-specific scripts? Regards, erdgeist
On 6 February 2012 16:38, Dirk Engling <erdgeist@erdgeist.org> wrote: > On 03.02.12 23:32, Chris Rees wrote: > >> Not a bad idea, but the standard procedure is documented in the >> Porter's Handbook [1] and is the way it is done in almost all ports. > > Well, so I am not sure how to continue? Open a maintainer update PR with > some patch? No, I'll commit it if you approve. >> The -n option is non-standard according to the cp manpage, and >> possibly it's never occurred to anyone to use that. > > non-standard meaning that other BSDs that could benefit from the > (Free)BSD ports do not have that? So is it a no-go to use even in very > BSD-specific scripts? No idea-- best to check whichever BSD you're looking at :) I would say no, and personally I stick to POSIX when writing any scripts-- it annoys me when people write bash scripts, so using BSD extensions in my scripts would be hypocritical... Chris
crees 2012-02-09 18:08:28 UTC FreeBSD ports repository Modified files: sysutils/ezjail Makefile pkg-plist Log: Copy over configuration file on install if not present PR: ports/164745 Submitted by: crees (me) Approved by: Dirk Engling (maintainer) Revision Changes Path 1.15 +6 -0 ports/sysutils/ezjail/Makefile 1.9 +2 -0 ports/sysutils/ezjail/pkg-plist _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Committed. Thanks!