Bug 164963 - [PATCH] ports-mgmt/porttools: add submit -P to print PR
Summary: [PATCH] ports-mgmt/porttools: add submit -P to print PR
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Chris Rees
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-10 16:30 UTC by John Hein
Modified: 2012-03-04 12:10 UTC (History)
1 user (show)

See Also:


Attachments
porttools-0.99_3.patch (3.62 KB, patch)
2012-02-10 16:30 UTC, John Hein
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Hein 2012-02-10 16:30:05 UTC
Add -P to print PR to stdout instead of submitting.  This allows the
sender to verify the PR before sending and possibly save the output to
paste into a mail client when an automated mailer (sendmail or some
other mailer to stuff in MAIL_AGENT) is unavailable or impractical to
use.

Also fix the comment in patch-cmd_submit.in that said support for
PORTEPOCH was added (looks like all of ports/154809 was not applied).
However it would probably be simpler to just remove the
PORTREVISION/PORTVERSION/PORTEPOCH logic used in port/154809 and just
use PKGNAME instead.

I'm ignoring the whitespace style mistakes in the PORTREVISION change
in patch-cmd_submit.in, but the committer could fix that if she feels
so inclined (and doesn't just refactor to use PKGNAME).


Added file(s):
- files/patch-port.1

Generated with FreeBSD Port Tools 0.99
Comment 1 Chris Rees freebsd_committer freebsd_triage 2012-02-17 09:37:16 UTC
State Changed
From-To: open->suspended

I'll take it, and get it in once ports/139872 is in. 


Comment 2 Chris Rees freebsd_committer freebsd_triage 2012-02-17 09:37:16 UTC
Responsible Changed
From-To: freebsd-ports-bugs->crees

I'll take it, and get it in once ports/139872 is in.
Comment 3 Chris Rees freebsd_committer freebsd_triage 2012-03-04 12:08:50 UTC
State Changed
From-To: suspended->closed

Committed. Thanks!
Comment 4 dfilter service freebsd_committer freebsd_triage 2012-03-04 12:08:57 UTC
crees       2012-03-04 12:08:43 UTC

  FreeBSD ports repository

  Modified files:
    ports-mgmt/porttools Makefile 
    ports-mgmt/porttools/files patch-cmd_submit.in patch-port.1 
  Log:
  Add -P option to print PR to stdout instead of submitting.
  
  PR:             ports/164963
  Submitted by:   John Hein <jhein@symmetricom.com>
  Approved by:    maintainer
  
  Revision  Changes    Path
  1.30      +1 -1      ports/ports-mgmt/porttools/Makefile
  1.3       +48 -12    ports/ports-mgmt/porttools/files/patch-cmd_submit.in
  1.2       +13 -2     ports/ports-mgmt/porttools/files/patch-port.1
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"