The attached patch has various simplifications/improvements for the port. Most importantly, it's currently installing the rc.d script from the source, rather than the fixed one in files/. The problem is that on 10-current the set_rcvar function has been removed from rc.subr. Since I had to look at it anyway (and since I use this port) I did a full cleanup for the script, and looked at the port more generally. 1. Remove 6.x compatibility hack 2. Use the PORTDOCS macro 3. Actually install the rc.d script in files 4. Simplify pkg-plist 5. For the rc.d script: a. Move it to the standard location, after LOGIN b. Add KEYWORD nojail per the script in the distfiles c. Put the standard arguments in their usual order/formats d. Simplify the assignments of pidfile and required_files e. Use command_args for required arguments, don't abuse _flags f. The test for -p in smartd_flags should be a start_precmd, we frown on running any code unconditionally. Also, improve this check if -p is first. g. Bring the reload and report options from the distfile version, and simplify them. You might also consider removing the @stopdaemon from pkg-plist altogether. Unless there is a really good reason do so it's frowned on to stop the service when deinstalling it. More information on the rc.d changes: http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html Fix: Apply the following patch: How-To-Repeat: DNA
Responsible Changed From-To: freebsd-ports-bugs->dougb Submitter has GNATS access (via the GNATS Auto Assign Tool)
Maintainer of sysutils/smartmontools, Please note that PR ports/165167 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/165167 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
I am approving the patch, thank you.
dougb 2012-02-15 08:46:57 UTC FreeBSD ports repository Modified files: sysutils/smartmontools Makefile pkg-plist sysutils/smartmontools/files smartd.in Log: This change has various simplifications/improvements for the port. Most importantly, it's currently installing the rc.d script from the source, rather than the fixed one in files/. 1. Remove 6.x compatibility hack 2. Use the PORTDOCS macro 3. Actually install the rc.d script in files/ 4. Simplify pkg-plist 5. For the rc.d script: a. Move it to the standard location, after LOGIN b. Add KEYWORD nojail per the script in the distfiles c. Put the standard arguments in their usual order/formats d. Simplify the assignments of pidfile and required_files e. Use command_args for required arguments, don't abuse _flags f. The test for -p in smartd_flags should be a start_precmd, we frown on running any code unconditionally. Also, improve this check if -p is first. g. Bring the reload and report options from the distfile version, and simplify them. PR: ports/165167 Submitted by: me Approved by: Alex Samorukov <samm@os2.kiev.ua> (maintainer) Revision Changes Path 1.57 +4 -4 ports/sysutils/smartmontools/Makefile 1.4 +51 -25 ports/sysutils/smartmontools/files/smartd.in 1.8 +1 -19 ports/sysutils/smartmontools/pkg-plist _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Committed, thanks!