Bug 165235 - [PATCH] multimedia/mplayer to use libgif
Summary: [PATCH] multimedia/mplayer to use libgif
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Dirk Meyer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-17 15:00 UTC by dirk.meyer
Modified: 2012-02-20 20:33 UTC (History)
0 users

See Also:


Attachments
file.diff (523 bytes, patch)
2012-02-17 15:00 UTC, dirk.meyer
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description dirk.meyer 2012-02-17 15:00:24 UTC
	mplayer uses libungif which is now dprecated
	mplayer detects libgif without problem
		if libungif is not installed.

Fix: Apply the patch.
	A bump of portrevision mmight be useful.
How-To-Repeat: 
Buildlog with patch:
===>  Vulnerability check disabled, database not found
===>  License GPLv2 accepted by the user
=> SHA256 Checksum OK for mplayer-1.0rc20111218.tar.xz.
===>  Patching for mplayer-1.0.r20111218_3
[...]
===>   mplayer-1.0.r20111218_3 depends on shared library: gif.5 - found
[...]
Checking for GIF support ... yes 
Checking for broken giflib workaround ... disabled 
[...]
    Codecs: libdv ffmpeg(internal) xanim libmpeg2(internal) mp3lib(internal) speex tremor(internal) gif 
    Audio output: oss mpegpes(file) 
    Video output: matrixview opengl gif89a pnm jpeg mpegpes(file) dga xv x11 xover yuv4mpeg md5sum tga 
[...]
===>  Installing for mplayer-current-1.0.r20111218_3
[...]
===>  Building package for mplayer-current-1.0.r20111218_3
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-02-17 15:00:33 UTC
Maintainer of multimedia/mplayer,

Please note that PR ports/165235 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/165235

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2012-02-17 15:00:37 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Thomas Zander 2012-02-18 11:33:53 UTC
Agreed, patch is good. Please go ahead, commit.

Thank you for the patch and best regards
Riggs
Comment 4 Mark Linimon freebsd_committer freebsd_triage 2012-02-18 13:48:33 UTC
State Changed
From-To: feedback->open

Maintainer approved.
Comment 5 dfilter service freebsd_committer freebsd_triage 2012-02-18 19:04:56 UTC
dinoex      2012-02-18 19:04:47 UTC

  FreeBSD ports repository

  Modified files:
    multimedia/mplayer   Makefile.options 
  Log:
  - move dependency to giflib
  PR:             165235
  
  Revision  Changes    Path
  1.28      +2 -2      ports/multimedia/mplayer/Makefile.options
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Dirk Meyer freebsd_committer freebsd_triage 2012-02-18 19:05:37 UTC
State Changed
From-To: open->closed

committed, thanks.
Comment 7 Philip M. Gollucci freebsd_committer freebsd_triage 2012-02-20 18:48:50 UTC
State Changed
From-To: closed->open

Maintainer approved
Comment 8 Dirk Meyer freebsd_committer freebsd_triage 2012-02-20 20:24:25 UTC
Responsible Changed
From-To: freebsd-ports-bugs->dinoex

I will take care of it.
Comment 9 Philip M. Gollucci freebsd_committer freebsd_triage 2012-02-20 20:33:23 UTC
State Changed
From-To: open->closed

Committed, Thanks!