[DESCRIBE CHANGES] Since r221388 and its MFCes SNDCTL_DSP_GETIPTR should work correctly on FreeBSD and should not require any quirks/workarounds. In fact they seem to be harmful now and result in sound outages. Port maintainer (aragon@phat.za.net) is cc'd. Generated with FreeBSD Port Tools 0.99
Maintainer of audio/alsa-plugins, Please note that PR ports/165247 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/165247 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
on 18/02/2012 21:20 Aragon Gouveia said the following: > Thanks for your submission! > > I presume this change will break the port on older releases, so it'd be good if > I can make the port apply the old patch for those still. Do you know the > nearest __FreeBSD_version before this was changed? This has been committed as r221388 to then head on May 3 2011, MFC-ed to stable/8 as r221583 on May 7 2011, and to stable/7 as r221584 on the same day. The nearest __FreeBSD_version bumps I could find are: - for head and stable/9: 900038 - stable/8: 802504 - stable/7: there has not been a __FreeBSD_version bump yet As such, 8.2 and 7.4 releases do not have the change. -- Andriy Gapon
Thanks for your submission! I presume this change will break the port on older releases, so it'd be good if I can make the port apply the old patch for those still. Do you know the nearest __FreeBSD_version before this was changed?
Hi. Sorry for dragging this out so long. Please find attached patch which I think does what I had in mind. I'm not very experienced with tracking changes in src, but for stable/9 I think you meant 900037 for the __FreeBSD_version bump? It occurred at r221862. Thanks!
Responsible Changed From-To: freebsd-ports-bugs->crees I'll take it.
Hey, Your patches look fine, but your .if tests in the Makefile resolve incorrectly (for example OSVERSION=900012 will get alsa-plugins-getiptrfix). How does the Makefile patch at [1] look? Your patchfiles are included in my working copy, but not in the diff for readability. Chris [1] http://www.bayofrum.net/~crees/patches/alsa-plugins-osversion-conditional.patch
Hey bud, Ah yes, good catch, thanks! Looks good. Please commit it. :) Thanks, Aragon
State Changed From-To: feedback->analyzed Taken for Tinderbox run
crees 2012-05-07 15:23:52 UTC FreeBSD ports repository Modified files: audio/alsa-plugins Makefile Added files: audio/alsa-plugins/files alsa-plugins-getiptrfix.patch alsa-plugins.patch Removed files: audio/alsa-plugins/files patch-alsa-plugins Log: Since r221388 and its MFCs SNDCTL_DSP_GETIPTR should work correctly on FreeBSD and should not require any quirks/workarounds. In fact they seem to be harmful now and result in sound outages. PR: ports/165247 Submitted by: avg Submitted by: Aragon Gouveia <aragon@phat.za.net> (maintainer) Revision Changes Path 1.5 +9 -1 ports/audio/alsa-plugins/Makefile 1.1 +564 -0 ports/audio/alsa-plugins/files/alsa-plugins-getiptrfix.patch (new) 1.1 +670 -0 ports/audio/alsa-plugins/files/alsa-plugins.patch (new) 1.2 +0 -670 ports/audio/alsa-plugins/files/patch-alsa-plugins (dead) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: analyzed->closed Committed. Thanks!
Andriy Gapon <avg@icyb.net.ua> writes: > Since r221388 and its MFCes SNDCTL_DSP_GETIPTR should work correctly > on FreeBSD and should not require any quirks/workarounds. > In fact they seem to be harmful now and result in sound outages. > Port maintainer (aragon@phat.za.net) is cc'd. The patch causes desync issue with alsa backend in libsydneyaudio as used by firefox (ports/169767), tested on /head@238294. It works fine both with previous version of alsa-plugins port and without ariff's patch at all. Can you confirm?
State Changed From-To: closed->open Problem :(
Hi. I think this PR can be closed as ports/171601 should address the desync issues that are reported here. Thanks!
State Changed From-To: open->closed Addressed in ports/171601