Bug 165369 - [PATCH] graphics/ocaml-images: migrate from libungif to giflib, mark MAKE_JOBS_UNSAFE
Summary: [PATCH] graphics/ocaml-images: migrate from libungif to giflib, mark MAKE_JOB...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Steve Wills
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-21 19:50 UTC by Steve Wills
Modified: 2012-02-25 21:10 UTC (History)
1 user (show)

See Also:


Attachments
ocaml-images-3.0.2_7,2.patch (713 bytes, patch)
2012-02-21 19:50 UTC, Steve Wills
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Wills freebsd_committer freebsd_triage 2012-02-21 19:50:06 UTC
See patch, which makes this use giflib instead of libungif. The two were
recently made to conflict and giflib is the prefered one. Also, include
MAKE_JOBS_UNSAFE since this failed to build for me with MAKE_JOBS enabled.

Port maintainer (michael.grunewald@laposte.net) is cc'd.

Generated with FreeBSD Port Tools 0.99_3 (mode: change, diff: CVS)
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-02-21 19:50:15 UTC
Responsible Changed
From-To: freebsd-ports-bugs->swills

Submitter has GNATS access (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2012-02-21 19:50:18 UTC
Maintainer of graphics/ocaml-images,

Please note that PR ports/165369 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/165369

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2012-02-21 19:50:21 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 Michaël Grünewald 2012-02-22 19:36:50 UTC
Hello Edwin and Steve,

Edwin Groothuis wrote:
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.

I reviewed and tested Steve's patch, and I think it can be committed.

Steve, I am working on bringing caml-images 4.0.1 into the ports, if you 
are willing to help, feel free to drop me a line!

Regards,
Michael
Comment 5 Steve Wills freebsd_committer freebsd_triage 2012-02-25 21:04:24 UTC
State Changed
From-To: feedback->closed

Committed.
Comment 6 dfilter service freebsd_committer freebsd_triage 2012-02-25 21:04:25 UTC
swills      2012-02-25 21:04:15 UTC

  FreeBSD ports repository

  Modified files:
    graphics/ocaml-images Makefile 
  Log:
  - Switch from libungif to giflib to avoid conflict
  - Mark MAKE_JOBS_UNSAFE since this failed for me with MAKE_JOBS enabled
  
  PR:             ports/165369
  Submitted by:   swills (myself)
  Approved by:    <michael.grunewald@laposte.net> (maintainer)
  
  Revision  Changes    Path
  1.40      +2 -1      ports/graphics/ocaml-images/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"