Bug 165454 - [patch] www/nginx: re-order extra_commands
Summary: [patch] www/nginx: re-order extra_commands
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Sergey A. Osokin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-24 17:30 UTC by Michael Scheidell
Modified: 2012-02-28 11:15 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Scheidell freebsd_committer freebsd_triage 2012-02-24 17:30:13 UTC
Can I beg for a small change to order of extra_commands in ../nginx rc file?
The way it is, anyone who want to add to this, with a /etc/rc.conf.d/nginx file won't get their 'special' hacks included.
By putting extra_commands ahead of the load_rc_config $name, it gives more of a standard ability for customizations.

this should be 100% upward compatible, don't need a portrevision bump, so no rebuilds needed, just makes it more comparible.
thanks.

- Update order of extra_commands in rc file to facilitate custom scripts
- no PORTREVISION bump

Fix: this small patch. thanks.



______________________________________________________________________
This email has been scanned and certified safe by SpammerTrap(r). 
For Information please see http://www.spammertrap.com/
______________________________________________________________________--3xiK01gaBwRVha68EwEuppTaO0TuiDCV0MS1ys9whwiXgjxV
Content-Type: text/plain; name="nginx.sh.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="nginx.sh.patch"

Index: files/nginx.sh.in
===================================================================
RCS file: /home/pcvs/ports/www/nginx/files/nginx.sh.in,v
retrieving revision 1.10
diff -u -r1.10 nginx.sh.in
--- files/nginx.sh.in	14 Jan 2012 08:57:15 -0000	1.10
+++ files/nginx.sh.in	24 Feb 2012 17:22:07 -0000
@@ -35,6 +35,7 @@
 _pidprefix="/var/run/nginx"
 pidfile="${_pidprefix}.pid"
 required_files=%%PREFIX%%/etc/nginx/nginx.conf
+extra_commands="reload configtest upgrade gracefulstop"
 
 [ -z "$nginx_enable" ]		&& nginx_enable="NO"
 [ -z "$nginxlimits_enable" ]	&& nginxlimits_enable="NO"
@@ -118,5 +119,4 @@
 	fi
 }
 
-extra_commands="reload configtest upgrade gracefulstop"
 run_rc_command "$1"
How-To-Repeat: 
add an extra command to /etc/rc.conf.d and execute service nginx {new command}
Comment 1 Jason Helfman freebsd_committer freebsd_triage 2012-02-24 18:52:58 UTC
Responsible Changed
From-To: freebsd-ports-bugs->osa

fix synopsis, and assign
Comment 2 dfilter service freebsd_committer freebsd_triage 2012-02-28 10:26:28 UTC
osa         2012-02-28 10:26:19 UTC

  FreeBSD ports repository

  Modified files:
    www/nginx/files      nginx.sh.in 
    www/nginx-devel/files nginx.sh.in 
  Log:
  Move upward extra_commands string for compatible with rc.conf.d
  feature.
  
  Do not bump PORTREVISIONs.
  PR:     165454
  
  Revision  Changes    Path
  1.13      +2 -2      ports/www/nginx-devel/files/nginx.sh.in
  1.11      +2 -2      ports/www/nginx/files/nginx.sh.in
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Sergey A. Osokin freebsd_committer freebsd_triage 2012-02-28 11:14:41 UTC
State Changed
From-To: open->closed

Committed, thanks for report!