- Fix build with curl 7.24.0: curl/types.h was removed (unused since Apr 2004) - Pet portlint Notified by: makc Port maintainer (bsdkaffee@gmail.com) is cc'd. Generated with FreeBSD Port Tools 0.99
Responsible Changed From-To: freebsd-ports-bugs->sunpoet Submitter has GNATS access (via the GNATS Auto Assign Tool)
Maintainer of audio/libofa, Please note that PR ports/165683 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/165683 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Thanks for the PR! I would prefer that the fix just be included in the already existing patch for the affected file. Attached is a diff to fix the port. - Jason --- 2012-03-04-libofa.diff begins here --- diff -ruN libofa.orig/Makefile libofa/Makefile --- libofa.orig/Makefile 2012-03-04 05:49:48.000000000 -0500 +++ libofa/Makefile 2012-03-04 05:50:48.000000000 -0500 @@ -14,6 +14,9 @@ MAINTAINER= bsdkaffee@gmail.com COMMENT= The Open Fingerprint Architecture Library +LICENSE= GPLv2 +LICENSE_FILE= ${WRKSRC}/COPYING + LIB_DEPENDS= fftw3:${PORTSDIR}/math/fftw3 \ expat.6:${PORTSDIR}/textproc/expat2 \ curl.6:${PORTSDIR}/ftp/curl @@ -28,7 +31,4 @@ MAKE_JOBS_SAFE= yes USE_LDCONFIG= yes -LICENSE= GPLv2 -LICENSE_FILE= ${WRKSRC}/COPYING - .include <bsd.port.mk> diff -ruN libofa.orig/files/patch-examples__protocol.cpp libofa/files/patch- examples__protocol.cpp --- libofa.orig/files/patch-examples__protocol.cpp 2012-03-04 05:49:48.000000000 -0500 +++ libofa/files/patch-examples__protocol.cpp 2012-03-04 05:53:55.000000000 -0500 @@ -1,6 +1,6 @@ ---- ./examples/protocol.cpp.orig 2011-03-18 11:01:22.000000000 -0400 -+++ ./examples/protocol.cpp 2011-03-18 11:01:22.000000000 -0400 -@@ -8,6 +8,7 @@ +--- ./examples/protocol.cpp.orig 2012-03-04 05:51:17.000000000 -0500 ++++ ./examples/protocol.cpp 2012-03-04 05:51:53.000000000 -0500 +@@ -8,11 +8,11 @@ -------------------------------------------------------------------*/ #include <stdio.h> #include <stdlib.h> @@ -8,3 +8,8 @@ #include <string> #include <map> #include <expat.h> + #include <curl/curl.h> +-#include <curl/types.h> + #include <curl/easy.h> + + using namespace std; --- 2012-03-04-libofa.diff ends here ---
State Changed From-To: feedback->closed Committed. Thanks!
sunpoet 2012-03-04 12:15:53 UTC FreeBSD ports repository Modified files: audio/libofa Makefile audio/libofa/files patch-examples__protocol.cpp Log: - Fix build with curl 7.24.0: curl/types.h was removed (unused since Apr 2004) - Pet portlint PR: ports/165683 Notified by: makc Submitted by: sunpoet (myself) Approved by: Jason E. Hale <bsdkaffee@gmail.com> (maintainer) Revision Changes Path 1.22 +3 -3 ports/audio/libofa/Makefile 1.2 +6 -1 ports/audio/libofa/files/patch-examples__protocol.cpp _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"