Bug 165826 - [PATCH] net/p5-Net-Nessus-XMLRPC: add missing DEPENDS
Summary: [PATCH] net/p5-Net-Nessus-XMLRPC: add missing DEPENDS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Steve Wills
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-07 17:00 UTC by Steve Wills
Modified: 2012-03-18 18:10 UTC (History)
1 user (show)

See Also:


Attachments
p5-Net-Nessus-XMLRPC-0.30_1.patch (954 bytes, patch)
2012-03-07 17:00 UTC, Steve Wills
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Wills freebsd_committer freebsd_triage 2012-03-07 17:00:25 UTC
see patch

Port maintainer (pauls@utdallas.edu) is cc'd.

Generated with FreeBSD Port Tools 0.99_3 (mode: change, diff: CVS)
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-03-07 17:00:41 UTC
Responsible Changed
From-To: freebsd-ports-bugs->perl

perl@ wants this port PRs (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2012-03-07 17:00:46 UTC
Maintainer of net/p5-Net-Nessus-XMLRPC,

Please note that PR ports/165826 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/165826

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2012-03-07 17:00:50 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 pauls 2012-03-07 17:24:46 UTC
--On March 7, 2012 11:00:46 AM -0600 Edwin Groothuis <edwin@FreeBSD.org> 
wrote:

> Maintainer of net/p5-Net-Nessus-XMLRPC,
>
> Please note that PR ports/165826 has just been submitted.
>
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
>
> The full text of the PR can be found at:
>     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/165826

According to the CPAN page 
(<http://search.cpan.org/~kost/Net-Nessus-XMLRPC-0.30/lib/Net/Nessus/XMLRPC.pm>), 
only IO::Socket::SSL is required (and in FreeBSD, Net::SSL is a RUN_DEPENDS 
for IO::Socket::SSL. anyway.)

"'This CPAN module uses LWP for communicating with Nessus over XMLRPC via 
https. Therefore, make sure that you have Net::SSL (provided by 
Crypt::SSLeay): http://search.cpan.org/perldoc?Crypt::SSLeay or 
IO::Socket::SSL: http://search.cpan.org/perldoc?IO::Socket::SSL"

If you want to argue that LWP is a RUN_DEPENDS, I can see that, but why 
HTML::Message and XML::Simple?  Why does the author think these other 
modules are required?

I need more information before making this change.

Even if these other modules were required, they wouldn't be BUILD_DEPENDS, 
they would be RUN_DEPENDS, so the patch would need to be corrected for that.

-- 
Paul Schmehl (pauls@utdallas.edu)
Senior Information Security Analyst
The University of Texas at Dallas
http://www.utdallas.edu/infosecurity/
Comment 5 Steve Wills freebsd_committer freebsd_triage 2012-03-14 03:07:40 UTC
Responsible Changed
From-To: perl->swills

I'll take it.
Comment 6 dfilter service freebsd_committer freebsd_triage 2012-03-18 18:04:23 UTC
swills      2012-03-18 18:04:09 UTC

  FreeBSD ports repository

  Modified files:
    net/p5-Net-Nessus-XMLRPC Makefile 
  Log:
  - Add missing DEPENDS
  - Bump PORTREVISION
  
  PR:             ports/165826
  Approved by:    Paul Schmehl <pauls@utdallas.edu> (maintainer)
  Feature safe:   yes
  
  Revision  Changes    Path
  1.3       +7 -1      ports/net/p5-Net-Nessus-XMLRPC/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 7 Steve Wills freebsd_committer freebsd_triage 2012-03-18 18:04:48 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!