When vinagre attempts to connect to a system running TightVNC V2, the connection is immediately closed due to an off-by-one error in src/gvnc.c. This results in sening back the version string without hte terminating newline. It appears that V1 didn'tmind, but V2 declres this a format error. This problem was reported in the Ubuntu forum at: https://bugs.launchpad.net/ubuntu/+source/gtk-vnc/+bug/598597 Fix: NOTE: This path is already in the upstream git repo and should appear in the next release. --- src/gvnc.c +++ src/gvnc.c @@ -3543,7 +3543,7 @@ gboolean gvnc_initialize(struct gvnc *gv gvnc->minor = 8; } - snprintf(version, 12, "RFB %03d.%03d\n", gvnc->major, gvnc->minor); + snprintf(version, 13, "RFB %03d.%03d\n", gvnc->major, gvnc->minor); gvnc_write(gvnc, version, 12); gvnc_flush(gvnc); GVNC_DEBUG("Using version: %d.%d", gvnc->major, gvnc->minor); How-To-Repeat: Attempt to connect to any TightVNC V2 server with vinagre or any tool using gtk-vnc.
Responsible Changed From-To: freebsd-ports-bugs->gnome Over to maintainer (via the GNATS Auto Assign Tool)
mezz 2012-03-17 17:38:00 UTC FreeBSD ports repository Modified files: net/gtk-vnc Makefile Added files: net/gtk-vnc/files patch-src_gvnc.c Log: Fix vinagre and possible other applications when trying to connect to TightVNC V2. Bump the PORTREVISION. PR: ports/166192 Submitted by: Kevin Oberman <rkoberman@gmail.com> Obtained from: Its git. Feature safe: yes Revision Changes Path 1.23 +1 -1 ports/net/gtk-vnc/Makefile 1.5 +11 -0 ports/net/gtk-vnc/files/patch-src_gvnc.c (new) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed, thanks!