Bug 166210 - [maintainer update] graphics/opennurbs
Summary: [maintainer update] graphics/opennurbs
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Michael Scheidell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-17 19:50 UTC by Fernando Apesteguía
Modified: 2012-03-22 18:10 UTC (History)
0 users

See Also:


Attachments
file.diff (5.44 KB, patch)
2012-03-17 19:50 UTC, Fernando Apesteguía
no flags Details | Diff
pr166210.patch (655 bytes, patch)
2012-03-22 11:02 UTC, Michael Scheidell
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fernando Apesteguía freebsd_committer freebsd_triage 2012-03-17 19:50:12 UTC
This update installs the library headers needed to compile against this library.

Fix: Apply the patch attached

Patch attached with submission follows:
Comment 1 Michael Scheidell freebsd_committer freebsd_triage 2012-03-19 10:04:25 UTC
Responsible Changed
From-To: freebsd-ports-bugs->scheidell

I'll take it.
Comment 2 Michael Scheidell freebsd_committer freebsd_triage 2012-03-19 14:04:03 UTC
State Changed
From-To: open->closed

Committed. Thanks!
Comment 3 Michael Scheidell freebsd_committer freebsd_triage 2012-03-21 22:43:46 UTC
State Changed
From-To: closed->open

MV's need to be changed to INSTALL_DATA
Comment 4 Michael Scheidell freebsd_committer freebsd_triage 2012-03-22 11:02:32 UTC
On 3/22/12 3:01 AM, Fernando Apestegu??a wrote:
> On Wed, Mar 21, 2012 at 11:43 PM,  <scheidell@freebsd.org> wrote:
>> Synopsis: [maintainer update] graphics/opennurbs
>>
>> State-Changed-From-To: closed->open
>> State-Changed-By: scheidell
>> State-Changed-When: Wed Mar 21 22:43:46 UTC 2012
>> State-Changed-Why:
>> MV's need to be changed to INSTALL_DATA
>
> MV's?
>
> Sorry but I don't know what you mean :S
>

The ports audit committee has requested that a change be made to the Makefile.
Instread of using 'mv' (move) to move the files to the target directory, they want you to use 'INSTALL_DATA'
(which by default is 'install -m 444').

Without this patch, this operation will fail:
make clean install
make deinstall
make install
(since there are no headers in the source directory anymore)

Could you test this patch? and if there is some reason you require move instead of install data, please get back to me ASAP?


-- 
Michael Scheidell, CTO
SECNAP Network Security Corporation
http://people.freebsd.org/~scheidell

______________________________________________________________________
This email has been scanned and certified safe by SpammerTrap(r). 
For Information please see http://www.spammertrap.com/
______________________________________________________________________  
  
Comment 5 Fernando Apesteguía freebsd_committer freebsd_triage 2012-03-22 14:44:14 UTC
On Thu, Mar 22, 2012 at 12:02 PM, Michael Scheidell
<scheidell@freebsd.org> wrote:
> On 3/22/12 3:01 AM, Fernando Apestegu=EDa wrote:
>> On Wed, Mar 21, 2012 at 11:43 PM, =A0<scheidell@freebsd.org> wrote:
>>> Synopsis: [maintainer update] graphics/opennurbs
>>>
>>> State-Changed-From-To: closed->open
>>> State-Changed-By: scheidell
>>> State-Changed-When: Wed Mar 21 22:43:46 UTC 2012
>>> State-Changed-Why:
>>> MV's need to be changed to INSTALL_DATA
>>
>> MV's?
>>
>> Sorry but I don't know what you mean :S
>>
>
> The ports audit committee has requested that a change be made to the Make=
file.
> Instread of using 'mv' (move) to move the files to the target directory, =
they want you to use 'INSTALL_DATA'
> (which by default is 'install -m 444').
>
> Without this patch, this operation will fail:
> make clean install
> make deinstall
> make install
> (since there are no headers in the source directory anymore)
>
> Could you test this patch? and if there is some reason you require move i=
nstead of install data, please get back to me ASAP?

Today (or tomorrow the latest) I can test your patch and send you feedback.

>
>
> --
> Michael Scheidell, CTO
> SECNAP Network Security Corporation
> http://people.freebsd.org/~scheidell
>
> ______________________________________________________________________
> This email has been scanned and certified safe by SpammerTrap(r).
> For Information please see http://www.spammertrap.com/
> ______________________________________________________________________
>
Comment 6 Fernando Apesteguía freebsd_committer freebsd_triage 2012-03-22 17:30:38 UTC
On Thu, Mar 22, 2012 at 3:44 PM, Fernando Apestegu=EDa
<fernando.apesteguia@gmail.com> wrote:
> On Thu, Mar 22, 2012 at 12:02 PM, Michael Scheidell
> <scheidell@freebsd.org> wrote:
>> On 3/22/12 3:01 AM, Fernando Apestegu=EDa wrote:
>>> On Wed, Mar 21, 2012 at 11:43 PM, =A0<scheidell@freebsd.org> wrote:
>>>> Synopsis: [maintainer update] graphics/opennurbs
>>>>
>>>> State-Changed-From-To: closed->open
>>>> State-Changed-By: scheidell
>>>> State-Changed-When: Wed Mar 21 22:43:46 UTC 2012
>>>> State-Changed-Why:
>>>> MV's need to be changed to INSTALL_DATA
>>>
>>> MV's?
>>>
>>> Sorry but I don't know what you mean :S
>>>
>>
>> The ports audit committee has requested that a change be made to the Mak=
efile.
>> Instread of using 'mv' (move) to move the files to the target directory,=
 they want you to use 'INSTALL_DATA'
>> (which by default is 'install -m 444').
>>
>> Without this patch, this operation will fail:
>> make clean install
>> make deinstall
>> make install
>> (since there are no headers in the source directory anymore)
>>
>> Could you test this patch? and if there is some reason you require move =
instead of install data, please get back to me ASAP?
>
> Today (or tomorrow the latest) I can test your patch and send you feedbac=
k.

I updated my ports today and applied the patch. It seems to work. All
the headers seem to be properly installed under
/usr/local/include/openNURBS/. The sequence:

make clean install
make deinstall
make install

doesn't fail anymore.

Thanks for the heads up and sorry for the inconvenience ;)

>
>>
>>
>> --
>> Michael Scheidell, CTO
>> SECNAP Network Security Corporation
>> http://people.freebsd.org/~scheidell
>>
>> ______________________________________________________________________
>> This email has been scanned and certified safe by SpammerTrap(r).
>> For Information please see http://www.spammertrap.com/
>> ______________________________________________________________________
>>
Comment 7 dfilter service freebsd_committer freebsd_triage 2012-03-22 17:36:30 UTC
scheidell    2012-03-22 17:36:16 UTC

  FreeBSD ports repository

  Modified files:
    graphics/opennurbs   Makefile 
  Log:
  - Change install from mv to install_data
  - No PORTREVISION bump (only affected reinstall without clean)
  
  PR:             ports/166210
  Reported by:    wxs@
  Approved by:    Fernando Apesteguía <fernando.apesteguia@gmail.com> (maintainer)
  Feature safe:   yes
  
  Revision  Changes    Path
  1.3       +2 -2      ports/graphics/opennurbs/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 8 Michael Scheidell freebsd_committer freebsd_triage 2012-03-22 17:36:32 UTC
State Changed
From-To: open->closed

Committed.