Bug 166271 - [PATCH] deskutils/kdepimlibs4 doesn't compile with clang
Summary: [PATCH] deskutils/kdepimlibs4 doesn't compile with clang
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-kde (group)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-20 03:10 UTC by heathn
Modified: 2012-04-15 19:50 UTC (History)
0 users

See Also:


Attachments
file.shar (1.44 KB, text/plain)
2012-03-20 03:10 UTC, heathn
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description heathn 2012-03-20 03:10:09 UTC
Building the kdepimlib4 project with clang results in 2 different compile time errors:

1) 
In file included from /usr/ports/deskutils/kdepimlibs4/work/kdepimlibs-4.7.4/kmime/kmime_codecs.cpp:40:
/usr/ports/deskutils/kdepimlibs4/work/kdepimlibs-4.7.4/kmime/kautodeletehash.h:67:26: error: use of undeclared identifier 'erase'
                         erase( QHash<Key, T *>::begin() );
                         ^
                         this->
/usr/ports/deskutils/kdepimlibs4/work/kdepimlibs-4.7.4/kmime/kmime_codecs.cpp:65:5: note: in instantiation of member function 'KMime::KAutoDeleteHash<QByteArray, KMime::Codec>::~KAutoDeleteHash' requested here
    delete all;
    ^
/usr/local/include/qt4/QtCore/qhash.h:466:14: note: must qualify identifier to find this declaration in dependent base class
    iterator erase(iterator it);
             ^

2)
usr/ports/deskutils/kdepimlibs4/work/kdepimlibs-4.7.4/kcal/listbase.h:118:13: error: use of undeclared identifier 'contains'
      if ( !contains( t ) ) {
            ^
            this->
/usr/ports/deskutils/kdepimlibs4/work/kdepimlibs-4.7.4/kcal/incidence.cpp:535:17: note: in instantiation of member function 'KCal::ListBase<KCal::Incidence>::removeRef' requested here
  d->mRelations.removeRef( incidence );
                ^
/usr/local/include/qt4/QtCore/qlist.h:163:11: note: must qualify identifier to find this declaration in dependent base class
    QBool contains(const T &t) const;
          ^

Fix: Patch is attached.

Patch attached with submission follows:
How-To-Repeat: cd /usr/ports/deskutils/kdepimlibs4
make install
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-03-20 03:10:54 UTC
Responsible Changed
From-To: freebsd-ports-bugs->kde

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2012-04-15 19:44:26 UTC
rakuco      2012-04-15 18:44:17 UTC

  FreeBSD ports repository

  Added files:
    deskutils/kdepimlibs4/files patch-git_b886894 
  Log:
  Fix build with clang.
  
  Import upstream commit b886894bd1afc515947c24883169d0a5107a86d5, which
  fixes the build with clang.
  
  Shouldn't be needed anymore when 4.8.x hits the tree.
  
  PR:             166271
  
  Revision  Changes    Path
  1.1       +32 -0     ports/deskutils/kdepimlibs4/files/patch-git_b886894 (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Raphael Kubo da Costa freebsd_committer freebsd_triage 2012-04-15 19:45:26 UTC
State Changed
From-To: open->closed

Thanks for the report. I ended up importing the upstream commit instead 
of your patch to make us deviate as little as possible from the upstream 
changes.