Modifications were requested to the resin rc script from dougb@ I am putting this pr in for approval and review Added file(s): - files/resin3.in Removed file(s): - files/resin3.sh.in Port maintainer (5u623l20@gmail.com) is cc'd. Generated with FreeBSD Port Tools 0.99_5 (mode: change, diff: CVS)
Responsible Changed From-To: freebsd-ports-bugs->jgh jgh@ wants this port PRs (via the GNATS Auto Assign Tool)
Maintainer of www/resin3, Please note that PR ports/166445 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/166445 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Hi Jason, Good to see you again. :D As far as I remember we got rid off the users problem running the application with www user and group. In that case don't you think we can get rid off the following variables from the rc file : +%%APP_NAME%%_user=${%%APP_NAME%%_user:-"%%USERS%%"} +%%APP_NAME%%_group=${%%APP_NAME%%_group:-"%%GROUPS%%"} Let me know your opinion please. Regards, Muhammad
On Wed, Mar 28, 2012 at 12:10:58AM +0600, Muhammad Moinur Rahman thus spake: >Hi Jason, > >Good to see you again. :D Good to see you too :) > >As far as I remember we got rid off the users problem running the >application with www user and group. In that case don't you think we can >get rid off the following variables from the rc file : > >+%%APP_NAME%%_user=${%%APP_NAME%%_user:-"%%USERS%%"} >+%%APP_NAME%%_group=${%%APP_NAME%%_group:-"%%GROUPS%%"} > >Let me know your opinion please. > >Regards, >Muhammad We didn't get rid of the USERS/GROUPS usage, though. We are using both of these, but using the www user and www group. Since it isn't configurable now, though, you have a a point, so it should at least be non-configurable in the rc script. Included is an updated patch. -jgh -- Jason Helfman | FreeBSD Committer jgh@FreeBSD.org | http://people.freebsd.org/~jgh
State Changed From-To: feedback->feedback Add misfiled PRs to Audit-Trail.
Responsible Changed From-To: jgh->jgh
State Changed From-To: feedback->open From misfiled PR ports/166461: Date: Wed, 28 Mar 2012 09:52:11 +0600
jgh 2012-04-02 23:51:25 UTC FreeBSD ports repository Modified files: www/resin3 Makefile Added files: www/resin3/files resin3.in Removed files: www/resin3/files resin3.sh.in Log: - reorg of rc script based on standards and move from .sh => .in - bump PORTREVISION PR: ports/166445 Submitted by: jgh (me) Approved by: maintainer, 5u623l20@gmail.com Feature safe: yes Revision Changes Path 1.47 +2 -1 ports/www/resin3/Makefile 1.1 +43 -0 ports/www/resin3/files/resin3.in (new) 1.2 +0 -43 ports/www/resin3/files/resin3.sh.in (dead) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed. Thanks!