TeamSpeak 3.0.3 from teamspeak.com
Responsible Changed From-To: freebsd-ports-bugs->scheidell I'll take it.
Richard: Thank you for stepping up and maintaing this port. FreeBSD would not be the operating system of choice for discriminating server operators without your help. I found a minor issue with port, maybe an old issue, but if you use pkg_add on this port it will not create the /var/{db|log}/teamspeak directories. (yes, make install does, via Makefile:post-install, but interesting thing about that: it doesn't get executed with a pkg_add ;-) Other issue, and it is more or less an internal cluster build issue, and I might change this later, is the .ifdef (PACKAGE_BUILDING) conditional in the Makefile. I needed it for tinderbox/pointyhat clusters to actually build the package) of course, I suppose both of these minor changes are not needed if you don't want the server OP to build a package with make package. how to replicate: on a clean system, or rm -rf /var/db/teamspeak /var/log/teamspeak make deinstall rm -rf /var/db/teamspeak /var/log/teamspeak make package make deinstall rm -rf /var/db/teamspeak /var/log/teamspeak pkg_add /usr/ports/packages/Latest/teamspeak.tbz notice: without my patches there is no /var/db/teamspeak. Do you approve of my minor changes? (apply this patch against CURRENT cvs, not against updated port) I can send you a portdir tarball if that would help. -- Michael Scheidell, CTO SECNAP Network Security Corporation http://people.freebsd.org/~scheidell ______________________________________________________________________ This email has been scanned and certified safe by SpammerTrap(r). For Information please see http://www.spammertrap.com/ ______________________________________________________________________
State Changed From-To: open->feedback Ask for maintainer approval.
it has been suggested that this would be the more appropriate patch .ifdef (BATCH) IGNORE= license ${LICENSE} needs confirmation, but BATCH is defined .endif -- Michael Scheidell, CTO >*| * SECNAP Network Security Corporation d: +1.561.948.2259 w: http://people.freebsd.org/~scheidell
scheidell 2012-05-04 18:26:13 UTC FreeBSD ports repository Modified files: audio/teamspeak3-server Makefile distinfo pkg-plist audio/teamspeak3-server/files pkg-message.in teamspeak.in Log: - Update to 3.0.3 [1] - Update LICENSE_PERMS [1] - Add @exec's to pkg-plist since Makefile:post-install isn't run with pkg-add [2] - Add BATCH check because you can't acctept license in batch mode [3] - Change mkdir/chown in Makefile (and pkg-plist) to install [3] PR: ports/166654 [1] Submitted by: Richard Hirner <hirner@bitfire.at> (maintainer) [1] Submitted by: scheidell (me) [2] Submitted by: crees@ [3] Revision Changes Path 1.22 +18 -8 ports/audio/teamspeak3-server/Makefile 1.13 +4 -4 ports/audio/teamspeak3-server/distinfo 1.4 +1 -1 ports/audio/teamspeak3-server/files/pkg-message.in 1.3 +4 -4 ports/audio/teamspeak3-server/files/teamspeak.in 1.10 +11 -3 ports/audio/teamspeak3-server/pkg-plist _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Committed, with minor changes. Please review. Thanks!
scheidell 2012-05-04 18:46:56 UTC FreeBSD ports repository Modified files: audio/teamspeak3-server Makefile audio/teamspeak3-server/files pkg-message.in Log: - Forgot SUB_LIST (without it, %%s didn't expand in rc script) - No PORTREVISION bump (caught before mirrors had a change to sync) PR: ports/166654 Submitted by: scheidell (me) Approved by: maintainer (implicit) Revision Changes Path 1.23 +3 -0 ports/audio/teamspeak3-server/Makefile 1.5 +1 -1 ports/audio/teamspeak3-server/files/pkg-message.in _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Seems to be OK for me (I'm not so experienced in port-making), just please make sure that the distfile from their server or other binaries NEVER get packaged/distributed automatically because the license doesn't allow that. Best regards, Richard