Bug 166853 - [patch] security/prelude-pflogger compilation when net/libpcap is installed
Summary: [patch] security/prelude-pflogger compilation when net/libpcap is installed
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Michael Scheidell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-11 19:10 UTC by Efren Yevale
Modified: 2012-05-08 20:46 UTC (History)
0 users

See Also:

Attachments
file.diff (370 bytes, patch)
2012-04-11 19:10 UTC, Efren Yevale 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Efren Yevale 2012-04-11 19:10:12 UTC 
Good day.

It seems you are unable to compile prelude-pflogger when lippcap is installed in your system.

Under this conditions the compilation fails due to the following:

===> Building for prelude-pflogger-0.9.0.r2_1
gmake all-recursive
gmake[1]: Entering directory `/usr/ports/security/prelude-pflogger/work/prelude-pflogger-0.9.0-rc2'
Making all in src
gmake[2]: Entering directory `/usr/ports/security/prelude-pflogger/work/prelude-pflogger-0.9.0-rc2/src'
Making all in include
gmake[3]: Entering directory `/usr/ports/security/prelude-pflogger/work/prelude-pflogger-0.9.0-rc2/src/include'
gmake[3]: Nothing to be done for `all'.
gmake[3]: Leaving directory `/usr/ports/security/prelude-pflogger/work/prelude-pflogger-0.9.0-rc2/src/include'
gmake[3]: Entering directory `/usr/ports/security/prelude-pflogger/work/prelude-pflogger-0.9.0-rc2/src'
source='process_packet.c' object='process_packet.o' libtool=no \
depfile='.deps/process_packet.Po' tmpdepfile='.deps/process_packet.TPo' \
depmode=gcc3 /bin/sh ../depcomp \
cc -I../ -I./include/ -I/usr/local/include -I. -I. -I.. -O2 -pipe -fno-strict-aliasing -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wbad-function-cast -Wcast-align -Wnested-externs -Wunused -c `test -f process_packet.c || echo './'`process_packet.c
In file included from process_packet.c:49:
/usr/include/net/bpf.h:65: error: redefinition of 'struct bpf_program'
/usr/include/net/bpf.h:1050: error: redefinition of 'struct bpf_insn'
gmake[3]: *** [process_packet.o] Error 1
gmake[3]: Leaving directory `/usr/ports/security/prelude-pflogger/work/prelude-pflogger-0.9.0-rc2/src'
gmake[2]: *** [all-recursive] Error 1
gmake[2]: Leaving directory `/usr/ports/security/prelude-pflogger/work/prelude-pflogger-0.9.0-rc2/src'
gmake[1]: *** [all-recursive] Error 1
gmake[1]: Leaving directory `/usr/ports/security/prelude-pflogger/work/prelude-pflogger-0.9.0-rc2'
gmake: *** [all] Error 2
*** Error code 1

Stop in /usr/ports/security/prelude-pflogger.

Fix: The patch provided for /usr/ports/security/prelude-pflogger/work/prelude-pflogger-0.9.0-rc2/src/process_packet.c changes the order in which the files net/bpf.h and pcap.h are included, the compilation succeeds after this with the command "make install clean".

I'm not sure if this is the best way to solve the problem but prelude-pflogger is working without problems on my system.

Patch attached with submission follows:
How-To-Repeat: Install libpcap:
cd /usr/ports/net/libpcap
make install clean

And try to install the port:
cd /usr/ports/security/prelude-pflogger
make install clean
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2012-04-16 04:59:43 UTC 
Responsible Changed
From-To: freebsd-i386->freebsd-ports-bugs

ports PR.
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2012-04-16 05:00:29 UTC 
Maintainer of security/prelude-pflogger,

Please note that PR ports/166853 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/166853

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2012-04-16 05:00:35 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 Anders Troback 2012-04-24 13:32:33 UTC 
Den Mon, 16 Apr 2012 04:00:29 UT
skrev Edwin Groothuis <edwin@FreeBSD.org>:

> Maintainer of security/prelude-pflogger,
> 
> Please note that PR ports/166853 has just been submitted.
> 
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
> 
> The full text of the PR can be found at:
>     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/166853
> 


I approve!
Comment 5 Michael Scheidell freebsd_committer freebsd_triage 2012-04-24 14:02:06 UTC 
State Changed
From-To: feedback->open

Maintainer has approved.
Comment 6 Michael Scheidell freebsd_committer freebsd_triage 2012-05-03 11:23:36 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->scheidell

I'll take it.
Comment 7 dfilter service freebsd_committer freebsd_triage 2012-05-08 20:07:23 UTC 
scheidell    2012-05-08 19:07:08 UTC

  FreeBSD ports repository

  Added files:
    security/prelude-pflogger/files patch-process_packet.c 
  Log:
  - Unbreak if ports libpcap installed
  - No PORTREVISION bump since this does not affect default
  
  PR:             ports/166853
  Submitted by:   Efren Yevale <syavne@gmail.com>
  Approved by:    Anders Troback <freebsd@troback.com> (maintainer)
  
  Revision  Changes    Path
  1.1       +14 -0     ports/security/prelude-pflogger/files/patch-process_packet.c (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 8 Michael Scheidell freebsd_committer freebsd_triage 2012-05-08 20:46:12 UTC 
State Changed
From-To: open->closed

Committed. Thanks!