Bug 166943 - ports/mail/postgrey package install fails
Summary: ports/mail/postgrey package install fails
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Chris Rees
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-14 14:00 UTC by Poul-Henning Kamp
Modified: 2012-04-18 19:09 UTC (History)
0 users

See Also:


Attachments
postgrey.patch.txt (969 bytes, text/plain)
2012-04-14 20:12 UTC, ports.maintainer
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Poul-Henning Kamp 2012-04-14 14:00:23 UTC
	### 08:51:05 ###   985 ###     2 ### install /usr/ports/mail/postgrey from /freebsd/Packages/postgrey-1.34_3.tbz
	---> Starting install script:
	---> Creating Postgrey database directory (/var/db/postgrey)
	chown: postgrey: illegal group name
	pkg_add: install script returned error status
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-04-14 14:00:32 UTC
Maintainer of mail/postgrey,

Please note that PR ports/166943 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/166943

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2012-04-14 14:00:34 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 ports.maintainer 2012-04-14 20:12:24 UTC
It looks like the step that creates the database directory happens 
before the user and group creation step when installing from package. 
The attached patch moves that step to the post-install stage.
Comment 4 Chris Rees freebsd_committer freebsd_triage 2012-04-14 21:36:52 UTC
Responsible Changed
From-To: freebsd-ports-bugs->crees

I'll take it.
Comment 5 Chris Rees 2012-04-15 13:16:41 UTC
Hi Darren,

Thanks for the quick fix!

I've also changed the perl dependencies to packages; SITE_PERL is
defined in bsd.perl.mk, and for various reasons we're trying to make
the ports tree work without bsd.perl.mk if possible.

Is the patch at [1] OK?

Chris

[1] http://www.bayofrum.net/~crees/patches/postgrey-fix-pkginstall.diff
Comment 6 ports.maintainer 2012-04-15 23:29:33 UTC
> Hi Darren,
>
> Thanks for the quick fix!
>
> I've also changed the perl dependencies to packages; SITE_PERL is
> defined in bsd.perl.mk, and for various reasons we're trying to make
> the ports tree work without bsd.perl.mk if possible.
>
> Is the patch at [1] OK?
>
> Chris
>
> [1]
> http://www.bayofrum.net/~crees/patches/postgrey-fix-pkginstall.diff

Why are there ">=0" version specifications for the dependencies?  Isn't 
that the same as saying any version, which is what you get without a 
version spec?

Note: GNATS does not forward follow-ups, so please make sure you keep 
ports.maintainer@evilphi.com in the CC list.
Comment 7 Chris Rees 2012-04-16 19:53:40 UTC
On 15 April 2012 23:29, Darren Pilgrim <ports.maintainer@evilphi.com> wrote=
:
>> Hi Darren,
>>
>> Thanks for the quick fix!
>>
>> I've also changed the perl dependencies to packages; SITE_PERL is
>> defined in bsd.perl.mk, and for various reasons we're trying to make
>> the ports tree work without bsd.perl.mk if possible.
>>
>> Is the patch at [1] OK?
>>
>> Chris
>>
>> [1]
>> http://www.bayofrum.net/~crees/patches/postgrey-fix-pkginstall.diff
>
>
> Why are there ">=3D0" version specifications for the dependencies? =A0Isn=
't that
> the same as saying any version, which is what you get without a version
> spec?

Without a version spec, it depends on a binary (i.e.
/usr/local/bin/p5-bluurgh).  The >=3D forces a package dependency.

Of course, if you know the actual versions for the deps, I'll happily
add those :)

Chris
Comment 8 ports.maintainer 2012-04-18 04:54:23 UTC
> Of course, if you know the actual versions for the deps, I'll
> happily add those :)

The only minimum version requirements are for Perl itself (5.6.0) and 
BerkleyDB (4.1).  Perl 5.6.0 isn't even in the tree anymore and 
p5-BerkeleyDB has USE_BDB=47+.

Chris Rees' patch approved.
Comment 9 dfilter service freebsd_committer freebsd_triage 2012-04-18 08:54:44 UTC
crees       2012-04-18 07:54:30 UTC

  FreeBSD ports repository

  Modified files:
    mail/postgrey        Makefile 
    mail/postgrey/files  pkg-install.in 
  Log:
  - Fix package installation; pre-install part of script depends on postgrey
    username existing.
  
  PR:             ports/166943
  Submitted by:   Darren Pilgrim <ports.maintainer@evilphi.com> (maintainer)
  
  - While here, use packages for perl dependencies to avoid requiring bsd.perl.mk
  
  Approved by:    Darren Pilgrim <ports.maintainer@evilphi.com> (maintainer)
  
  Revision  Changes    Path
  1.34      +9 -7      ports/mail/postgrey/Makefile
  1.6       +6 -5      ports/mail/postgrey/files/pkg-install.in
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 10 Chris Rees freebsd_committer freebsd_triage 2012-04-18 19:09:06 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!