Bug 167488 - [PATCH] graphics/lprof-devel: Make the port build with CMake 2.8.8
Summary: [PATCH] graphics/lprof-devel: Make the port build with CMake 2.8.8
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-01 15:20 UTC by Raphael Kubo da Costa
Modified: 2012-05-02 20:40 UTC (History)
1 user (show)

See Also:

Attachments
lprof-devel-20080514_8.patch (6.83 KB, patch)
2012-05-01 15:20 UTC, Raphael Kubo da Costa 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa freebsd_committer freebsd_triage 2012-05-01 15:20:12 UTC 
Note: this PR currently blocks ports/167140, which updates CMake to 2.8.8.

lprof-devel used SET_DIRECTORY_PROPERTIES(PROPERTIES INCLUDE_DIRECTORIES)
instead of the more standard INCLUDE_DIRECTORIES() call to add directories to a
target's include path.

This only worked by chance, and a change in CMake 2.8.8 breaks this altogether:
<http://article.gmane.org/gmane.comp.programming.tools.cmake.devel/3625>

The attached patch replaces the current calls in a way that hopefully achieves
the same results.

Another possibility is to just mark the port as BROKEN: looking at the build
system code, there are many other ugly things it does, plus upstream seems to
have been dead for at least 4 years and no port depends on it.

Added file(s):
- files/patch-src-3rdparty-vigra-CMakeLists.txt
- files/patch-src-ICCtoIT8-CMakeLists.txt
- files/patch-src-lcms-CMakeLists.txt
- files/patch-src-liblprof-CMakeLists.txt

Port maintainer (amdmi3@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.99_6 (mode: change, diff: CVS)
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-05-01 15:20:26 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->amdmi3

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Dmitry Marakasov freebsd_committer freebsd_triage 2012-05-02 20:31:33 UTC 
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!
Comment 3 dfilter service freebsd_committer freebsd_triage 2012-05-02 20:31:36 UTC 
amdmi3      2012-05-02 19:31:17 UTC

  FreeBSD ports repository

  Modified files:
    graphics/lprof-devel/files patch-src-CMakeLists.txt 
                               patch-src-argyll-CMakeLists.txt 
  Added files:
    graphics/lprof-devel/files 
                               patch-src-3rdparty-vigra-CMakeLists.txt 
                               patch-src-ICCtoIT8-CMakeLists.txt 
                               patch-src-lcms-CMakeLists.txt 
                               patch-src-liblprof-CMakeLists.txt 
  Log:
  - Change SET_DIRECTORY_PROPERTIES(INCLUDE_DIRECTORIES) to INCLUDE_DIRECTORIES in cmake scripts to prepare for cmake 2.8.8
  
  PR:             167488
  Submitted by:   Raphael Kubo da Costa <rakuco@FreeBSD.org>
  
  Revision  Changes    Path
  1.1       +15 -0     ports/graphics/lprof-devel/files/patch-src-3rdparty-vigra-CMakeLists.txt (new)
  1.2       +25 -4     ports/graphics/lprof-devel/files/patch-src-CMakeLists.txt
  1.1       +17 -0     ports/graphics/lprof-devel/files/patch-src-ICCtoIT8-CMakeLists.txt (new)
  1.2       +17 -2     ports/graphics/lprof-devel/files/patch-src-argyll-CMakeLists.txt
  1.1       +14 -0     ports/graphics/lprof-devel/files/patch-src-lcms-CMakeLists.txt (new)
  1.1       +15 -0     ports/graphics/lprof-devel/files/patch-src-liblprof-CMakeLists.txt (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"