Bug 167528 - [PATCH] devel/p5-Data-TreeDumper: Add required dependency p5-Class-ISA
Summary: [PATCH] devel/p5-Data-TreeDumper: Add required dependency p5-Class-ISA
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Andrej Zverev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-02 16:10 UTC by Wayne Sierke
Modified: 2012-11-19 13:33 UTC (History)
1 user (show)

See Also:


Attachments
p5-Data-TreeDumper-0.40.patch (761 bytes, patch)
2012-05-02 16:10 UTC, Wayne Sierke
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wayne Sierke 2012-05-02 16:10:09 UTC
Revert removal of required dependency p5-Class-ISA

Dependency on p5-Class-ISA was removed in rev 1.16 in favour of p5-Check-ISA, but both are required.
See:
http://deps.cpantesters.org/?module=Data%3A%3ATreeDumper;perl=latest

Port maintainer (dhn@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.99_6 (mode: change, diff: CVS)

How-To-Repeat: Install graphics/asciio on a system with devel/p5-Class-ISA

%asciio
Can't locate Class/ISA.pm in @INC (@INC contains: /usr/local/lib/perl5/5.14.2/BSDPAN /usr/local/lib/perl5/site_perl/5.14.2/mach /usr/local/lib/perl5/site_perl/5.14.2 /usr/local/lib/perl5/5.14.2/mach /usr/local/lib/perl5/5.14.2 .) at /usr/local/lib/perl5/site_perl/5.14.2/Data/TreeDumper.pm line 38.
BEGIN failed--compilation aborted at /usr/local/lib/perl5/site_perl/5.14.2/Data/TreeDumper.pm line 38.
Compilation failed in require at /usr/local/lib/perl5/site_perl/5.14.2/App/Asciio.pm line 9.
BEGIN failed--compilation aborted at /usr/local/lib/perl5/site_perl/5.14.2/App/Asciio.pm line 9.
Compilation failed in require at /usr/local/bin/asciio line 15.
BEGIN failed--compilation aborted at /usr/local/bin/asciio line 15.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-05-02 16:10:24 UTC
Responsible Changed
From-To: freebsd-ports-bugs->dhn

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Wayne Sierke 2012-05-03 07:13:08 UTC
Some more info. Looks like Class::ISA was removed from perl-5.14

> >How-To-Repeat:
> Install graphics/asciio on a system with devel/p5-Class-ISA

s/with/without/

"and with perl-5.14 installed."


# pkg_info -L perl-5.12.4_4 | grep ISA
/usr/local/lib/perl5/5.12.4/perl/man/man3/Class::ISA.3.gz
/usr/local/lib/perl5/5.12.4/Class/ISA.pm
#
%pkg_info -L perl-5.14.2_2 | grep ISA
%

So probably something like the following is needed.

Note that I've only made a guess about the correctness of the PERL_LEVEL
test; I have not verified it.


--- p5-Data-TreeDumper-0.40.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/devel/p5-Data-TreeDumper/Makefile,v
retrieving revision 1.19
diff -u -r1.19 Makefile
--- Makefile    21 Jan 2012 17:37:52 -0000      1.19
+++ Makefile    3 May 2012 05:59:56 -0000
@@ -19,10 +19,17 @@
                ${SITE_PERL}/Check/ISA.pm:${PORTSDIR}/devel/p5-Check-ISA \
                ${SITE_PERL}/${PERL_ARCH}/Devel/Size.pm:${PORTSDIR}/devel/p5-Devel-Size \
                ${SITE_PERL}/Sort/Naturally.pm:${PORTSDIR}/textproc/p5-Sort-Naturally
+
+.include <bsd.port.pre.mk>
+
+.if ${PERL_LEVEL} >= 501400
+BUILD_DEPENDS+=        ${SITE_PERL}/Class/ISA.pm:${PORTSDIR}/devel/p5-Class-ISA
+.endif
+
 RUN_DEPENDS:=  ${BUILD_DEPENDS}
 
 MAN3=          Data::TreeDumper.3
 
 PERL_CONFIGURE=        yes
 
-.include <bsd.port.mk>
+.include <bsd.port.post.mk>
--- p5-Data-TreeDumper-0.40.patch ends here ---
Comment 3 Andrej Zverev freebsd_committer freebsd_triage 2012-11-05 20:33:55 UTC
Responsible Changed
From-To: dhn->az

Maintainer timeout
Comment 4 Andrej Zverev freebsd_committer freebsd_triage 2012-11-19 13:33:01 UTC
State Changed
From-To: open->closed

Committed. Sorry it took so long.