Bug 167726 - FreeBSD patch for graphics/gthumb-2.14.1_1 is just plain wrong
Summary: FreeBSD patch for graphics/gthumb-2.14.1_1 is just plain wrong
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Pav Lucistnik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-09 06:00 UTC by Ronald F. Guilmette
Modified: 2012-05-10 15:36 UTC (History)
0 users

See Also:

Attachments
file.diff (713 bytes, patch)
2012-05-09 06:00 UTC, Ronald F. Guilmette 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ronald F. Guilmette 2012-05-09 06:00:27 UTC 
There is file currently present in the ports tree called:

   /usr/ports/graphics/gthumb/files/patch-glib-utils.c

This patch (or something like it) is indeed necessary in order to make
gthumb-2.14.x build successfully.  However the patch itself is quite
self-evidently wrong.  It causes `offset' to always be set to zero,
to no apparently useful effect (since the value gets re-set to the
value of tm->tm_gmtoff just two lines further down in the code) and
also, the patch in question fails to make allowances for possible
host systems where neither HAVE_TM_GMTOFF nor HAVE_TIMEZONE are defined.

A more correct patch for gthumb-2.14.x is provided below.

How-To-Repeat: 
	cd /usr/ports/graphics/gthumb
	make
Comment 1 Michael Scheidell freebsd_committer freebsd_triage 2012-05-09 14:27:43 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->pav

GNATS got confused.  Over to maintainer of graphics/gthumb
Comment 2 Pav Lucistnik freebsd_committer freebsd_triage 2012-05-10 15:36:36 UTC 
State Changed
From-To: open->closed

This is largely cosmetic, since FreeBSD systems will always configure to 
HAVE_TM_GMTOFF variant, but applied anyway.