htop uses linux compability layer for memory calculation, but this incorrect for FreeBSD. Fix: Patch attached --- ./configure.ac.orig 2011-12-26 23:46:57.000000000 +0200 +++ ./configure.ac 2012-05-16 17:39:50.000000000 +0300 @@ -23,11 +23,12 @@ # Checks for libraries. AC_CHECK_LIB([m], [ceil], [], [missing_libraries="$missing_libraries libm"]) +AC_CHECK_LIB([kvm], [kvm_open], [], [missing_libraries="$missing_libraries libkvm"]) # Checks for header files. AC_HEADER_DIRENT AC_HEADER_STDC -AC_CHECK_HEADERS([stdlib.h string.h strings.h sys/param.h sys/time.h unistd.h curses.h],[:],[ +AC_CHECK_HEADERS([stdlib.h string.h strings.h sys/param.h sys/time.h unistd.h curses.h kvm.h paths.h fcntl.h sys/sysctl.h],[:],[ missing_headers="$missing_headers $ac_header" ]) AC_CHECK_HEADERS([execinfo.h],[:],[:]) --- patch-configure.ac ends here --- How-To-Repeat: Install htop & compare memory values reported by htop and top from base system
Maintainer of sysutils/htop, Please note that PR ports/167970 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/167970 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Oops, formatting is wrong. I can resend patches if needed.
Patches resend
Yes, I approve this patch. Please commit it. 2012/5/16 Edwin Groothuis <edwin@freebsd.org>: > Maintainer of sysutils/htop, > > Please note that PR ports/167970 has just been submitted. > > If it contains a patch for an upgrade, an enhancement or a bug fix > you agree on, reply to this email stating that you approve the patch > and a committer will take care of it. > > The full text of the PR can be found at: > =A0 =A0http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dports/167970 > > -- > Edwin Groothuis via the GNATS Auto Assign Tool > edwin@FreeBSD.org
State Changed From-To: feedback->open Maintainer approved.
pawel 2012-05-29 21:22:56 UTC FreeBSD ports repository Modified files: sysutils/htop Makefile Added files: sysutils/htop/files patch-ProcessList.c patch-configure.ac Log: Add patches to show correct memory usage on FreeBSD PR: ports/167970 Submitted by: Sayetsky Anton <vsjcfm@gmail.com> Approved by: maintainer Revision Changes Path 1.24 +1 -0 ports/sysutils/htop/Makefile 1.7 +73 -0 ports/sysutils/htop/files/patch-ProcessList.c (new) 1.6 +16 -0 ports/sysutils/htop/files/patch-configure.ac (new) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed. Thanks!