Bug 168129 - graphics/zathura fix makefile
Summary: graphics/zathura fix makefile
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-19 08:40 UTC by graudeejs
Modified: 2012-05-19 11:20 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description graudeejs 2012-05-19 08:40:01 UTC
post-install:	.SILENT
	${CAT} pkg-message

Is incorrect it should be

post-install:	.SILENT
	@${CAT} ${PKGMESSAGE}


Perhaps even withiut .SILENT

post-patch also contains .SILENT I dunno why

Fix: 

post-install:	.SILENT
	@${CAT} ${PKGMESSAGE}
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-05-19 08:40:10 UTC
Maintainer of graphics/zathura,

Please note that PR ports/168129 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/168129

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2012-05-19 08:40:12 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Quentin Stievenart 2012-05-19 09:03:11 UTC
Right, I didn't knew about ${PKGMESSAGE}. .SILENT is just there to
avoid putting a @ in front of every line, but for a one-line
post-install I agree that it is simpler to just put a @. So
post-install should be:

post-install:
@${CAT} ${PKGMESSAGE}


2012/5/19 Edwin Groothuis <edwin@freebsd.org>:
> Maintainer of graphics/zathura,
>
> Please note that PR ports/168129 has just been submitted.
>
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
>
> The full text of the PR can be found at:
> =A0 =A0http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dports/168129
>
> --
> Edwin Groothuis via the GNATS Auto Assign Tool
> edwin@FreeBSD.org
Comment 4 dfilter service freebsd_committer freebsd_triage 2012-05-19 11:16:34 UTC
pawel       2012-05-19 10:16:25 UTC

  FreeBSD ports repository

  Modified files:
    graphics/zathura     Makefile 
  Log:
  Use ${PKGMESSAGE}
  
  PR:             ports/168129
  Submitted by:   Aldis Berjoza <graudeejs@gmail.com>
  approved by:    Quentin Stievenart <acieroid@awesom.eu> (maintainer)
  
  Revision  Changes    Path
  1.12      +2 -2      ports/graphics/zathura/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Pawel Pekala freebsd_committer freebsd_triage 2012-05-19 11:16:52 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!