Bug 168311 - [patch] sysutils/uhidd: unbreak after yacc update in r235723
Summary: [patch] sysutils/uhidd: unbreak after yacc update in r235723
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Alex Kozlov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-24 18:20 UTC by Jan Beich
Modified: 2012-05-27 13:26 UTC (History)
0 users

See Also:


Attachments
yacc.diff (538 bytes, patch)
2012-05-24 18:20 UTC, Jan Beich
no flags Details | Diff
yacc.diff (1.27 KB, patch)
2012-05-24 18:29 UTC, Jan Beich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2012-05-24 18:20:02 UTC
How-To-Repeat: $ make
clang -O2 -pipe -I. -I/usr/ports/sysutils/uhidd/work/uhidd-0.2.0/uhidd -g -fno-omit-frame-pointer -std=gnu99 -Qunused-arguments -fstack-protector -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -Wno-empty-body -Wno-string-plus-int -c parser.c
parser.y:214:2: error: implicitly declaring library function 'exit' with type 'void (int) __attribute__((noreturn))' [-Werror]
        exit(1);
        ^
parser.y:214:2: note: please include the header <stdlib.h> or explicitly provide a declaration for 'exit'
parser.y:224:10: error: implicit declaration of function 'strtoul' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
        value = strtoul(hex, NULL, 16);
                ^
In file included from y.tab.c:460:
/usr/include/stdlib.h:112:3: error: conflicting types for 'strtoul'
         strtoul(const char * __restrict, char ** __restrict, int);
         ^
parser.y:224:10: note: previous implicit declaration is here
        value = strtoul(hex, NULL, 16);
                ^
3 errors generated.
*** [parser.o] Error code 1
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-05-24 18:20:09 UTC
Maintainer of sysutils/uhidd,

Please note that PR ports/168311 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/168311

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2012-05-24 18:20:12 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Jan Beich freebsd_committer freebsd_triage 2012-05-24 18:29:54 UTC
Oops, previous FreeBSD releases slipped my mind. And there is one more error.

$ make CC=gcc46
[...]
y.tab.c:113:12: error: redundant redeclaration of 'yyparse' [-Werror=redundant-decls]
parser.y:42:12: note: previous declaration of 'yyparse' was here
cc1: all warnings being treated as errors
*** [parser.o] Error code 1
Comment 4 kaiwang27 2012-05-26 22:02:43 UTC
Patch approved.

Thanks,
Kai
Comment 5 Mark Linimon freebsd_committer freebsd_triage 2012-05-26 22:22:01 UTC
State Changed
From-To: feedback->open

Maintainer approved.
Comment 6 Alex Kozlov freebsd_committer freebsd_triage 2012-05-27 09:54:57 UTC
Responsible Changed
From-To: freebsd-ports-bugs->ak

I'll take it.
Comment 7 dfilter service freebsd_committer freebsd_triage 2012-05-27 10:14:20 UTC
ak          2012-05-27 09:14:07 UTC

  FreeBSD ports repository

  Modified files:
    sysutils/uhidd       Makefile 
  Added files:
    sysutils/uhidd/files extra-patch-uhidd-parser.y 
  Log:
  - Unbreak after yacc update in r235723
  
  PR:     ports/168311
  Submitted by:   Jan Beich <jbeich@tormail.org>
  Approved by:    eadler, itetcu (mentors, implicit)
  
  Revision  Changes    Path
  1.7       +2 -0      ports/sysutils/uhidd/Makefile
  1.1       +17 -0     ports/sysutils/uhidd/files/extra-patch-uhidd-parser.y (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 8 Alex Kozlov freebsd_committer freebsd_triage 2012-05-27 13:26:52 UTC
State Changed
From-To: open->closed

Committed. Thanks!