Update desmume to 0.9.8 Fix: Patch attached with submission follows:
Responsible Changed From-To: freebsd-ports-bugs->rene rene@ wants his PRs (via the GNATS Auto Assign Tool)
Maintainer of emulators/desmume, Please note that PR ports/168356 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/168356 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Looks good to me. On Sat, May 26, 2012 at 6:40 PM, Edwin Groothuis <edwin@freebsd.org> wrote: > Maintainer of emulators/desmume, > > Please note that PR ports/168356 has just been submitted. > > If it contains a patch for an upgrade, an enhancement or a bug fix > you agree on, reply to this email stating that you approve the patch > and a committer will take care of it. > > The full text of the PR can be found at: > =A0 =A0http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dports/168356 > > -- > Edwin Groothuis via the GNATS Auto Assign Tool > edwin@FreeBSD.org
The build fails for me in libfat : http://rene-ladan.nl:8080/tb/errors/7-FreeBSD/desmume-0.9.8.log http://rene-ladan.nl:8080/tb/errors/8-FreeBSD/desmume-0.9.8.log (and also on a 10.X-amd64 box) In file included from utils/libfat/common.h:87, from utils/libfat/cache.cpp:40: utils/libfat/libfat_pc.h:108: error: 'mode_t_' has not been declared utils/libfat/libfat_pc.h:109: error: 'mode_t_' has not been declared Maybe an include file is missing?
The removed REINPLACE_CMD fixed that originally -- not sure where mode_t_t comes from but it should be mode_t. I'll get off my butt and get everything working tonight, sorry 'bout that. On Thu, May 31, 2012 at 4:52 AM, Ren=E9 Ladan <rene@freebsd.org> wrote: > The build fails for me in libfat : > > http://rene-ladan.nl:8080/tb/errors/7-FreeBSD/desmume-0.9.8.log > http://rene-ladan.nl:8080/tb/errors/8-FreeBSD/desmume-0.9.8.log > (and also on a 10.X-amd64 box) > > In file included from utils/libfat/common.h:87, > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 from utils/libfat/cache.cpp:40: > utils/libfat/libfat_pc.h:108: error: 'mode_t_' has not been declared > utils/libfat/libfat_pc.h:109: error: 'mode_t_' has not been declared > > Maybe an include file is missing?
I was getting a similar error, so I simply tried removing the REINPLACE_CMD and it just worked. With the patch I sent the build completed and now I have it running. (9-i386) Build is failing here with both the original REINPLACE_CMD (as before) and replacing with mode_t_t. Maybe sys/_types.h should be included in ${WRKSRC}/src/utils/libfat/cache.cpp. orig ? BTW, I forgot to remove PORTREVISION.
I actually can't repro the mode_t_ issues with the supplied patch -- it seems to work for me as-is. Can you post your /etc/make.conf, /var/db/ports/desmume/options, or anything else you can think of that would influence the build? The links supplied are currently inaccessible for me. On Thu, May 31, 2012 at 4:52 AM, Ren=E9 Ladan <rene@freebsd.org> wrote: > The build fails for me in libfat : > > http://rene-ladan.nl:8080/tb/errors/7-FreeBSD/desmume-0.9.8.log > http://rene-ladan.nl:8080/tb/errors/8-FreeBSD/desmume-0.9.8.log > (and also on a 10.X-amd64 box) > > In file included from utils/libfat/common.h:87, > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 from utils/libfat/cache.cpp:40: > utils/libfat/libfat_pc.h:108: error: 'mode_t_' has not been declared > utils/libfat/libfat_pc.h:109: error: 'mode_t_' has not been declared > > Maybe an include file is missing?
2012/6/1 L Campbell <lcampbell@uncod.in>: > I actually can't repro the mode_t_ issues with the supplied patch -- > it seems to work for me as-is. > Upon closer inspection it works for me as-is too (at least on 10.X-amd64, tinderbox still running). I manually redid the patch instead of downloadin= g it because it is a small patch and I noticed that the PORTREVISION line could be removed but then I overlooked removing the " @${REINPLACE_CMD} -e 's|mode_t|mode_t_|g' " line. Ren=E9 > Can you post your /etc/make.conf, /var/db/ports/desmume/options, or > anything else you can think of that would influence the build? The > links supplied are currently inaccessible for me. > Oops, they got removed by the monthly tinderbox cleanup. > On Thu, May 31, 2012 at 4:52 AM, Ren=E9 Ladan <rene@freebsd.org> wrote: >> The build fails for me in libfat : >> >> http://rene-ladan.nl:8080/tb/errors/7-FreeBSD/desmume-0.9.8.log >> http://rene-ladan.nl:8080/tb/errors/8-FreeBSD/desmume-0.9.8.log >> (and also on a 10.X-amd64 box) >> >> In file included from utils/libfat/common.h:87, >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 from utils/libfat/cache.cpp:40: >> utils/libfat/libfat_pc.h:108: error: 'mode_t_' has not been declared >> utils/libfat/libfat_pc.h:109: error: 'mode_t_' has not been declared >> >> Maybe an include file is missing?
2012/5/31 L Campbell <lcampbell@uncod.in>: > The removed REINPLACE_CMD fixed that originally -- not sure where > mode_t_t comes from but it should be mode_t. I'll get off my butt and > get everything working tonight, sorry 'bout that. > It fails on 7.X because the port Makefile redefines __APPLE__ as 1 causing the nonexistent file AvailabilityMacros.h to be included from ${WRKSRC}/src/utils/libfat/directory.cpp So adding the missing strnlen() function, for which this redefine hack is m= eant, has to be done differently. Ren=E9
Can you please try this patch on 7.x? http://pastebin.com/TEXWKuxU
rene 2012-06-04 18:05:59 UTC FreeBSD ports repository Modified files: emulators/desmume Makefile distinfo Log: Update to 0.9.8 PR: ports/168356 Submitted by: Barbara Approved by: maintainer Revision Changes Path 1.22 +4 -4 ports/emulators/desmume/Makefile 1.7 +2 -2 ports/emulators/desmume/distinfo _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Committed, thanks