Bug 168541 - png-1.4.11 to png-1.5.10 upgrade breaks graphics/xfig-devel
Summary: png-1.4.11 to png-1.5.10 upgrade breaks graphics/xfig-devel
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Dirk Meyer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-01 23:30 UTC by david
Modified: 2012-06-03 15:21 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description david 2012-06-01 23:30:10 UTC 
	Per the 20120531 entry in /usr/ports/UPDATING, I issued
	"portmaster -r png-" to update both graphics/png and
	everything that depends on it.

	After updating all of the ports on which xfig-devel depends, the
	attempt to re-build graphics/xfig-devel failed:

	...
	rm -f e_scale.o
	cc -c -O2 -pipe -fno-strict-aliasing       -I/usr/local/X11 -I/usr/local/include
	 -I/usr/local/include/X11 -I/usr/local/include    -DCSRG_BASED  -DFUNCPROTO=15 -
	 DNARROWPROTO                                                     -DUSE_INLINE -D
	 USE_XPM -DXAW3D -DXAW3D1_5E                     -DUSE_JPEG -DI18N     e_scale.c
	 cc -O2 -pipe -fno-strict-aliasing       -I/usr/local/X11 -I/usr/local/include -I
	 /usr/local/include/X11 -I/usr/local/include    -DCSRG_BASED  -DFUNCPROTO=15 -DNA
	 RROWPROTO                                                -DUSE_INLINE -DUSE_XPM 
	 -DXAW3D -DXAW3D1_5E                     -DUSE_JPEG -DI18N   -c e_tangent.c
	 rm -f e_update.o
	 cc -c -O2 -pipe -fno-strict-aliasing       -I/usr/local/X11 -I/usr/local/include -I/usr/local/include/X11 -I/usr/local/include    -DCSRG_BASED  -DFUNCPROTO=15 -DNARROWPROTO                                                     -DUSE_INLINE -DUSE_XPM -DXAW3D -DXAW3D1_5E                     -DUSE_JPEG -DI18N     e_update.c
	 rm -f f_load.o
	 cc -c -O2 -pipe -fno-strict-aliasing       -I/usr/local/X11 -I/usr/local/include -I/usr/local/include/X11 -I/usr/local/include    -DCSRG_BASED  -DFUNCPROTO=15 -DNARROWPROTO                                                     -DUSE_INLINE -DUSE_XPM -DXAW3D -DXAW3D1_5E                     -DUSE_JPEG -DI18N     f_load.c
	 cc -O2 -pipe -fno-strict-aliasing       -I/usr/local/X11 -I/usr/local/include -I/usr/local/include/X11 -I/usr/local/include    -DCSRG_BASED  -DFUNCPROTO=15 -DNARROWPROTO                                                -DUSE_INLINE -DUSE_XPM -DXAW3D -DXAW3D1_5E                     -DUSE_JPEG -DI18N   -c f_neuclrtab.c
	 rm -f f_picobj.o
	 cc -c -O2 -pipe -fno-strict-aliasing       -I/usr/local/X11 -I/usr/local/include -I/usr/local/include/X11 -I/usr/local/include    -DCSRG_BASED  -DFUNCPROTO=15 -DNARROWPROTO                                                     -DUSE_INLINE -DUSE_XPM -DXAW3D -DXAW3D1_5E                     -DUSE_JPEG -DI18N     f_picobj.c
	 rm -f f_read.o
	 cc -c -O2 -pipe -fno-strict-aliasing       -I/usr/local/X11 -I/usr/local/include -I/usr/local/include/X11 -I/usr/local/include    -DCSRG_BASED  -DFUNCPROTO=15 -DNARROWPROTO                                                     -DUSE_INLINE -DUSE_XPM -DXAW3D -DXAW3D1_5E                     -DUSE_JPEG -DI18N     f_read.c
	 cc -O2 -pipe -fno-strict-aliasing       -I/usr/local/X11 -I/usr/local/include -I/usr/local/include/X11 -I/usr/local/include    -DCSRG_BASED  -DFUNCPROTO=15 -DNARROWPROTO                                                -DUSE_INLINE -DUSE_XPM -DXAW3D -DXAW3D1_5E                     -DUSE_JPEG -DI18N   -c f_readold.c
	 cc -O2 -pipe -fno-strict-aliasing       -I/usr/local/X11 -I/usr/local/include -I/usr/local/include/X11 -I/usr/local/include    -DCSRG_BASED  -DFUNCPROTO=15 -DNARROWPROTO                                                -DUSE_INLINE -DUSE_XPM -DXAW3D -DXAW3D1_5E                     -DUSE_JPEG -DI18N   -c f_readppm.c
	 cc -O2 -pipe -fno-strict-aliasing       -I/usr/local/X11 -I/usr/local/include -I/usr/local/include/X11 -I/usr/local/include    -DCSRG_BASED  -DFUNCPROTO=15 -DNARROWPROTO                                                -DUSE_INLINE -DUSE_XPM -DXAW3D -DXAW3D1_5E                     -DUSE_JPEG -DI18N   -c f_readpng.c
	 f_readpng.c: In function 'read_png':
	 f_readpng.c:73: error: dereferencing pointer to incomplete type
	 f_readpng.c:90: error: dereferencing pointer to incomplete type
	 f_readpng.c:91: error: dereferencing pointer to incomplete type
	 f_readpng.c:95: error: dereferencing pointer to incomplete type
	 f_readpng.c:97: error: dereferencing pointer to incomplete type
	 *** Error code 1

	 Stop in /common/ports/graphics/xfig-devel/work/xfig.3.2.5-alpha5.
	 *** Error code 1

	 Stop in /common/ports/graphics/xfig-devel.
	 *** Error code 1

	 Stop in /common/ports/graphics/xfig-devel.

	 ===>>> make failed for graphics/xfig-devel
	 ===>>> Aborting update

	 Terminated

How-To-Repeat: 	As above.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-06-02 08:17:57 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->lesi

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dirk.meyer 2012-06-02 11:05:32 UTC 
building xfig or xfig-devel fails here before reacjing png specific files.

e_edit.c: In function 'str_panel':
e_edit.c:4358: error: 'XtNinternational' undeclared (first use in this function)
e_edit.c:4358: error: (Each undeclared identifier is reported only once
e_edit.c:4358: error: for each function it appears in.)

Please try the patch below.
kind regards Dirk

- Dirk Meyer, Im Grund 4, 34317 Habichtswald, Germany
- [dirk.meyer@dinoex.sub.org],[dirk.meyer@guug.de],[dinoex@FreeBSD.org]
http://people.freebsd.org/~dinoex/errorlogs/


--- f_readpng.c.orig	2004-01-06 20:46:05.000000000 +0100
+++ f_readpng.c	2012-06-02 11:51:52.000000000 +0200
@@ -70,7 +70,7 @@
     }
 
     /* set long jump recovery here */
-    if (setjmp(png_ptr->jmpbuf)) {
+    if (setjmp(png_jmpbuf(png_ptr))) {
 	/* if we get here there was a problem reading the file */
 	png_destroy_read_struct(&png_ptr, &info_ptr, &end_info);
 	close_picfile(file,filetype);
Comment 3 Dirk Meyer freebsd_committer freebsd_triage 2012-06-03 15:10:03 UTC 
Responsible Changed
From-To: lesi->dinoex

I will take care of it.
Comment 4 dfilter service freebsd_committer freebsd_triage 2012-06-03 15:10:39 UTC 
dinoex      2012-06-03 14:10:27 UTC

  FreeBSD ports repository

  Added files:
    graphics/xfig-devel/files patch-f_readpng.c patch-f_wrpng.c 
  Log:
  - fix build with libpng 1.5.10
  PR:             168541
  Obtained from:  gentoo
  
  Revision  Changes    Path
  1.1       +47 -0     ports/graphics/xfig-devel/files/patch-f_readpng.c (new)
  1.1       +19 -0     ports/graphics/xfig-devel/files/patch-f_wrpng.c (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Dirk Meyer freebsd_committer freebsd_triage 2012-06-03 15:21:15 UTC 
State Changed
From-To: open->closed


a fix has been committed, thanks.