A FreeBSD version of 'archey' utility, which is used to display system information in a nice looking way.
Hi, There was a missmatch in the distinfo file I submitted. I'm attaching a new, SHAfile with the corrected distfile.I have submitted: SHA256 (bsdinfo-0.1.tar.gz) = 1abf6b174a40dba85e6080e7ebae426759c17699f9d34402e93937cb6f036e40 SIZE (bsdinfo-0.1.tar.gz) = 3950 Which is incorrect, due to github cloud cache (I accidentally did 'make makesum' on a cached package). Correct checksums are: SHA256 (bsdinfo-0.1.tar.gz) = 1baffe4ec1a20ed9ba26022f23ff90869eab368d13d466668fe23da6cc88eecf SIZE (bsdinfo-0.1.tar.gz) = 33280 I apologize for any inconvienence. -- Best Regards, Jakub 'samu' Szafra??ski
Responsible Changed From-To: freebsd-ports-bugs->scheidell I'll take it.
State Changed From-To: open->feedback And I get a different value altogether. Attempting to fetch http://cloud.github.com/downloads/samaelszafran/bsdinfo/bsdinfo-0.1.tar.gz fetch: http://cloud.github.com/downloads/samaelszafran/bsdinfo/bsdinfo-0.1.tar.gz: size mismatch: expected 33280, actual 3964 Are you the author of bsdinfo? or can we pull this from the official distribution site instead?
Yes, I am the author of bsdinfo. It is currently available only on github, but I can mirror it on some other servers (if it got to the ports tree, it would also be mirrored on the freebsd.org ftp, if I'm correct). So, I'm sorry, the issue was the distinfo file. By mistake I've generated it (using make makesum) from a .tar file, instead of a .tar.gz file. Here is the correct distinfo file: SHA256 (bsdinfo-0.1.tar.gz) = 90a98a1249706fde625b3c72f479ac1a9f63f81668ccde9ecf43fbbe6b6d7e5c SIZE (bsdinfo-0.1.tar.gz) = 3964 The remote file (http://cloud.github.com/downloads/samaelszafran/bsdinfo/bsdinfo-0.1.tar.gz) is 100% correct, I've only created wrong checksums by mistake. I will also commit the new distfile to my github repository within a minute (https://github.com/samaelszafran/bsdinfo/tree/master/sysutils/bsdinfo). I really apologize for that mistake. -- Best regards, Jakub Szafra??ski
State Changed From-To: feedback->suspended Several issues with this port, and unless you can get them fixed in the next two weeks, I suggest that you close this pr and open a new one when you are ready. First (and in no particular order) it won't package. your ports Makefile calls for a man page. your source has no man page (I don't think it needs on, there are no options) Second, the license in bsdinfo.c is not BSD compatible. I suggest you look at /usr/ports/Mk/bsd.license* and pick a compatible license, edit your source to use that license (please pick a BSD compatible license) and edit ports Makefile to use the license. Third, your OPTION doesn't do anything. with and without x256, it builds a color version. this is because the src/Makefile has no options one way or the other, your CONFIGURE_ARGS does nothing, since you don't have a ./configure script Forth, your code has no options, if you build this with color support, you should follow conventions and allow for 'no color' during runtime. (--no-color ?), and/or make sure it only attempts to display colur if TERM env variable == xterm ? Fifth, your src/Makefile has no options for changes to LOCALBASE or PREFIX, and will force install into /usr/local Sixth, your src/Makefile does not honor CFLAGS/ CC env variable, etc. Seventh, your ports Makefile has this (which is wrong) portlint -abt should complain a lot: (you should not use the .include <bsd.port.options.mk> its not needed. (and, again, CONFIGURE_ARGS is useless if you don't have auto_conf, and a configure script in your src). you need to find a different way to do this: (and you have it backwards? OPTIONS= X256 "Build 256 color version" Off .if !defined(WITH_X256) CONFIGURE_ARGS+=--xterm-256 .endif .include <bsd.port.options.mk> .include <bsd.port.mk> something like: .if !defined(WITHOUT_X256) @${REINPLACE_CMD} -e "s/c bsdinfo-xterm-256.c//" ${WRKSRC}/Makefile .endif Eighth, you included a pkg-plist for one file. portlint -abt would have warned you about this. delete that file and add this to your ports Makefile: PLIST_FILES+= bin/bsdinfo Ninth, you src Makefile installs with 'cp' you should use $INSTALL_EXEC. As I said, I will suspend this pr for two weeks, and if you come up with fixes for it, I will commit them. If not, close this pr and open a brand new one with a new shar. Join the freebsd-ports email list and ask questions. Re-read the porters-handbook on FreeBSD.org. All this will help you.
Okay, so, I did most of the points you suggested. 1) I have changed the licence in all files in which the licence was included - i am not sure if it is required to have a LICENCE variable in the Makefile though. 2) The code (by default) builds a 16-colour version of bsdinfo. If the user selects X256 in the option dialog (which I have fixed, according to your instructions), the 256 colour version will be built. 3) In fact, the TERM variable does not determine wheter or not the terminal will be able to display 256 colors (or even 16 colors) properly (I am able to display it correctly without the TERM variable at all). I think that such detection should be made using termcap, but this will be added in further releases of bsdinfo. 4) I have changed the Makefile according to your instructions, and as far as I have tested - it works fine (CC/CFLAGS, different prefix, configure_args added by option dialogs, etc). I could not find, however, any information about LOCALBASE (neither in ports(7) nor anywhere via google). PREFIX works fine, though - is it enough? I am attaching the latest shar file. If there are any problems with this port - please infor me. As you can see, I am trying to fix them as soon as possible. -- Best regards, Jakub Szafra??ski
State Changed From-To: suspended->open Don't have time for this now.
Responsible Changed From-To: scheidell->freebsd-ports-bugs Back to the pool
Responsible Changed From-To: freebsd-ports-bugs->wxs I'll take it.
State Changed From-To: open->closed Committed. Thanks!
wxs 2012-06-22 13:54:24 UTC FreeBSD ports repository Modified files: sysutils Makefile Added files: sysutils/bsdinfo Makefile distinfo pkg-descr Log: This is a FreeBSD attempt to implement archey-like terminal system information display utility. It is just an esthetic way to display system information. Right now it doesn't have any configurable options (different themes, switches to change behaviour, etc), but I will add such features in the future, perhaps. WWW: https://github.com/samaelszafran/bsdinfo PR: ports/168832 Submitted by: s@samu.pl Revision Changes Path 1.1418 +1 -0 ports/sysutils/Makefile 1.1 +29 -0 ports/sysutils/bsdinfo/Makefile (new) 1.1 +2 -0 ports/sysutils/bsdinfo/distinfo (new) 1.1 +7 -0 ports/sysutils/bsdinfo/pkg-descr (new) _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"