Bug 168902 - Make graphics/libGL compile with clang (using WITH_NEW_XORG)
Summary: Make graphics/libGL compile with clang (using WITH_NEW_XORG)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: freebsd-x11 (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-09 22:10 UTC by Dimitry Andric
Modified: 2012-06-10 06:50 UTC (History)
0 users

See Also:

Attachments
file.diff (7.49 KB, patch)
2012-06-09 22:10 UTC, Dimitry Andric 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitry Andric freebsd_committer freebsd_triage 2012-06-09 22:10:15 UTC 
As described in <http://docs.freebsd.org/cgi/mid.cgi?4F9BC101.8090305>,
recent versions of MesaLib can't be compiled with clang, due to its use
of nested functions.

This has already been fixed in Mesa upstream, specifically in
<http://cgit.freedesktop.org/mesa/mesa/commit/?id=4aa1ac5fe94b5696095229ee3568bf4fa7cfed95>,
but this has not yet been put into the 8.0.3 release.

Fix: See attached diff, which applies the upstream fix to our port.


Patch attached with submission follows:
How-To-Repeat: WITH_NEW_XORG=yo CC=clang CXX=clang++ make -C /usr/ports/graphics/dri
(or any other graphics/libGL dependent port)
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-06-10 00:41:59 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->freebsd-x11

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2012-06-10 06:47:57 UTC 
miwi        2012-06-10 05:47:43 UTC

  FreeBSD ports repository

  Modified files:
    graphics/libGL       bsd.mesalib.mk 
  Added files:
    graphics/libGL/files 
                         extra-src__mesa__drivers__dri__nouveau__nouveau_array.c 
                         extra-src__mesa__drivers__dri__nouveau__nouveau_render_t.c 
  Log:
  - Unbreak build with clang
  
  PR:             168902
  Submitted by:   dim@
  Tested by:      O. Hartmann" <ohartman@zedat.fu-berlin.de>
  
  Revision  Changes    Path
  1.20      +4 -2      ports/graphics/libGL/bsd.mesalib.mk
  1.1       +99 -0     ports/graphics/libGL/files/extra-src__mesa__drivers__dri__nouveau__nouveau_array.c (new)
  1.1       +91 -0     ports/graphics/libGL/files/extra-src__mesa__drivers__dri__nouveau__nouveau_render_t.c (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Martin Wilke freebsd_committer freebsd_triage 2012-06-10 06:48:00 UTC 
State Changed
From-To: open->closed

thanks committed.