Bug 169040 - audio/ario: Converted to OptionsNG
Summary: audio/ario: Converted to OptionsNG
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Sylvio Cesar Teixeira
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-13 17:40 UTC by Grzegorz Blach
Modified: 2012-06-22 02:00 UTC (History)
0 users

See Also:


Attachments
file.diff (519 bytes, patch)
2012-06-13 17:40 UTC, Grzegorz Blach
no flags Details | Diff
audio_ario.diff (499 bytes, patch)
2012-06-19 20:57 UTC, Grzegorz Blach
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Grzegorz Blach 2012-06-13 17:40:08 UTC
Port audio/ario converted to OptionsNG framework

Fix: Patch attached with submission follows:
Comment 1 Sylvio Cesar Teixeira freebsd_committer freebsd_triage 2012-06-14 00:15:19 UTC
Responsible Changed
From-To: freebsd-ports-bugs->sylvio

I'll take it.
Comment 2 dfilter service freebsd_committer freebsd_triage 2012-06-17 20:52:00 UTC
sylvio      2012-06-17 19:51:49 UTC

  FreeBSD ports repository

  Modified files:
    audio/ario           Makefile 
  Log:
  - Converted to OptionsNG framework
  
  PR:             ports/169040
  Submitted by:   Grzegorz Blach <magik@roorback.net> (maintainer)
  
  Revision  Changes    Path
  1.18      +5 -4      ports/audio/ario/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Sylvio Cesar Teixeira freebsd_committer freebsd_triage 2012-06-17 20:52:02 UTC
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!
Comment 4 Grzegorz Blach 2012-06-18 20:43:20 UTC
ario configuration now is broken:

1. OPTIONS_DEFINE= NLS override OPTIONS_DEFINE=	AVAHI, so only NLS
option is available during 'make config'

2. AVAHI_DESC is defined in Mk/bsd.options.desc.mk, it isn't necessary
to override this variable with similar message

3. Porter handbook suggest use WITHOUT_NLS variable to choose using
gettext or not. Also I think /etc/make.conf is better place to set this
variable, than port Makefile, so I removed NLS option.


Please revert your patch and commit my patch without changes.
Comment 5 Chris Rees freebsd_committer freebsd_triage 2012-06-18 21:03:46 UTC
On 18 June 2012 20:43, Grzegorz Blach <magik@roorback.net> wrote:
> ario configuration now is broken:
>
> 1. OPTIONS_DEFINE= NLS override OPTIONS_DEFINE= AVAHI, so only NLS
> option is available during 'make config'
>
> 2. AVAHI_DESC is defined in Mk/bsd.options.desc.mk, it isn't necessary
> to override this variable with similar message
>
> 3. Porter handbook suggest use WITHOUT_NLS variable to choose using
> gettext or not. Also I think /etc/make.conf is better place to set this
> variable, than port Makefile, so I removed NLS option.

NLS is also in PORT_OPTIONS, and the code handles it correctly;

i.e. WITH_NLS in make.conf sets option NLS.

I'll clarify the docs.

Chris
Comment 6 Grzegorz Blach 2012-06-19 20:57:54 UTC
New/old patch
Comment 7 dfilter service freebsd_committer freebsd_triage 2012-06-22 01:57:00 UTC
sylvio      2012-06-22 00:56:45 UTC

  FreeBSD ports repository

  Modified files:
    audio/ario           Makefile 
  Log:
  - Fixed problem with OptionsNG
  
  PR:             ports/169040
  Submitted by:   maintainer(private email)
  
  Revision  Changes    Path
  1.19      +1 -2      ports/audio/ario/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"