Bug 169174 - [patch] sysutils/htop: fix swap size calculation on i386
Summary: [patch] sysutils/htop: fix swap size calculation on i386
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Michael Scheidell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-17 09:20 UTC by vsjcfm
Modified: 2012-07-09 01:20 UTC (History)
0 users

See Also:

Attachments
patch-Makefile (250 bytes, text/plain)
2012-06-17 09:20 UTC, vsjcfm 		no flags Details
file.diff (732 bytes, patch)
2012-06-17 09:20 UTC, vsjcfm 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description vsjcfm 2012-06-17 09:20:09 UTC 
There is an error in my previous htop patch. Swap values can overflow on i386.

Fix: Patch for previous patch attached.
How-To-Repeat: Install htop 1.0.1_1 and create swap >2GiB, you will see a value of -2097152MiB
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-06-17 09:20:51 UTC 
Maintainer of sysutils/htop,

Please note that PR ports/169174 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/169174

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2012-06-17 09:20:56 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Michael Scheidell freebsd_committer freebsd_triage 2012-07-09 00:10:03 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->scheidell

I'll take it.
Comment 4 dfilter service freebsd_committer freebsd_triage 2012-07-09 01:12:22 UTC 
scheidell    2012-07-09 00:12:10 UTC

  FreeBSD ports repository

  Modified files:
    sysutils/htop        Makefile 
    sysutils/htop/files  patch-ProcessList.c 
  Log:
  - Fix swap size calculation on i386
  - Bump PORTREVISION
  
  PR:             ports/169174
  Submitted by:   vsjcfm@gmail.com
  Approved by:    maintainer (timeout,14 days)
  
  Revision  Changes    Path
  1.25      +1 -1      ports/sysutils/htop/Makefile
  1.8       +2 -2      ports/sysutils/htop/files/patch-ProcessList.c
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 Michael Scheidell freebsd_committer freebsd_triage 2012-07-09 01:12:30 UTC 
State Changed
From-To: feedback->closed

Committed. Thanks!