Bug 169223 - [PATCH] emulators/virtualbox-ose: fix usage of ${SRC_BASE} before it is defined
Summary: [PATCH] emulators/virtualbox-ose: fix usage of ${SRC_BASE} before it is defined
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Jason Helfman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-19 00:50 UTC by Jason Helfman
Modified: 2012-07-02 00:50 UTC (History)
1 user (show)

See Also:


Attachments
virtualbox-ose-4.1.16_1.patch (1.59 KB, patch)
2012-06-19 00:50 UTC, Jason Helfman
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Helfman freebsd_committer freebsd_triage 2012-06-19 00:50:22 UTC
Original PR filed as ports/165994

SRC_BASE is being used before being defined in several ports. it happened to
work anyways in most cases because the main use of SRC_BASE is for checking if
${SRC_BASE}/sys/ (/usr/src/sys/) exists, and if SRC_BASE is empty, it just
checks for /sys/ which does exist on most systems as a symlink to /usr/src/sys/.

pet portlint on license placement

Port maintainer (vbox@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.99_6 (mode: change, diff: CVS)
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-06-19 00:51:02 UTC
Responsible Changed
From-To: freebsd-ports-bugs->vbox

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Jason Helfman freebsd_committer freebsd_triage 2012-07-01 07:34:55 UTC
Responsible Changed
From-To: vbox->jgh

maintainer timeout (14 days)
Comment 3 dfilter service freebsd_committer freebsd_triage 2012-07-01 23:52:55 UTC
jgh         2012-07-01 22:52:41 UTC

  FreeBSD ports repository

  Modified files:
    emulators/virtualbox-ose Makefile 
  Log:
  - re-order, include bsd.port.pre.mk so SRC_BASE is defined before referenced
  - pet portlint on placement of LICENSE
  
  PR:     ports/169223
  Submitted by:   jgh@
  Approved by:    maintainer timeout ( 14 days )
  
  Revision  Changes    Path
  1.54      +5 -5      ports/emulators/virtualbox-ose/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 4 Jason Helfman freebsd_committer freebsd_triage 2012-07-02 00:09:07 UTC
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!
Comment 5 dfilter service freebsd_committer freebsd_triage 2012-07-02 00:41:41 UTC
jgh         2012-07-01 23:41:31 UTC

  FreeBSD ports repository

  Modified files:
    emulators/virtualbox-ose Makefile 
  Log:
  - revert previous commit, index breakage
  
  PR:     ports/169223
  VS: ----------------------------------------------------------------------
  
  Revision  Changes    Path
  1.55      +5 -5      ports/emulators/virtualbox-ose/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"