Patch to update graphics/openimageio to v1.0.6 The patch doesn't appear to include info to delete files/* - the patches there can be deleted as they have been merged upstream. Is that a switch I am missing in diff? Fix: Patch attached with submission follows:
Responsible Changed From-To: freebsd-ports-bugs->madpilot I'll take it.
Hi, Thanks for your submission. There is no special flag to fully remove files, you can use the -N flag which sill make them empty after applying the patch(will show all content as removed in the patch). It's quite handy for committers if you specify removed and added files explicitly in the description of your submissions. I'm testing your patch and noticed you are using ABI version numbers in the LIB_DEPENDS, portlint reports this: WARN: Makefile: LIB_DEPENDS don't specify the ABI version number .6 in IlmImf.6 unless it is really necessary. WARN: Makefile: LIB_DEPENDS don't specify the ABI version number .4 in boost_thread.4 unless it is really necessary. WARN: Makefile: LIB_DEPENDS don't specify the ABI version number .2 in opencv_legacy.2 unless it is really necessary. WARN: Makefile: LIB_DEPENDS don't specify the ABI version number .4 in tbb.4 unless it is really necessary. WARN: Makefile: LIB_DEPENDS don't specify the ABI version number .2 in webp.2 unless it is really necessary. As portliny states, are you sure you need to wire the exact abi version? If a minimum requirement exists you can code it as a "glob" like foo.[3-9]* if you simply don't care about the ABI version it would be best to simply remove it like: webp:${PORTSDIR}/graphics/webp and let the ports system manage it. I can remove them myself before committing if you approve. Or, if some strict requirement needs to be there you can file an updated patch. Thanks! -- Guido Falsi <madpilot@FreeBSD.org>
Hi, Looking better at your submission I converted it to the new options framework. I also removed the libraries ABI versions. I'm attaching a patch for you to approve. Thanks. -- Guido Falsi <madpilot@FreeBSD.org>
State Changed From-To: open->feedback Ask for maintainer approval.
I attached the wrong file. Sorry for my mistake, please disregard previous patch. -- Guido Falsi <madpilot@FreeBSD.org>
Having just looked over the info for the new options framework I see no problems with the changes you have made. The only change I would add is to add docs=on but that can wait for the next update.
State Changed From-To: feedback->open Maintainer has approved.
madpilot 2012-06-26 11:38:56 UTC FreeBSD ports repository Modified files: graphics/openimageio Makefile distinfo pkg-plist Removed files: graphics/openimageio/files patch-src_iv_imageviewer.cpp patch-src_ptex.imageio_ptex_Ptexture.h Log: - Update to 1.0.6 - Convert to new options framework - Make DOCS options default to on, as per maintainer request PR: ports/169288 Submitted by: Shane Ambler <FreeBSD@Shaneware.biz> Approved by: crees (mentor) Revision Changes Path 1.6 +14 -13 ports/graphics/openimageio/Makefile 1.3 +2 -2 ports/graphics/openimageio/distinfo 1.2 +0 -14 ports/graphics/openimageio/files/patch-src_iv_imageviewer.cpp (dead) 1.2 +0 -17 ports/graphics/openimageio/files/patch-src_ptex.imageio_ptex_Ptexture.h (dead) 1.4 +1 -1 ports/graphics/openimageio/pkg-plist _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed. Thanks!