169481 – [patch] sysutils/puppet fails to install packages

no flags

When using puppet with the default options, trying to install a package with a
manifest including for example the following lines will fail:

------ [beginning of manifest] ------
  [...]
  package { "sysutils/tmux":
    ensure => installed,
  }
  [...]
--------- [end of manifest] ---------

------ [beginning of failure details] ------
# puppet agent --test --debug
[...]
debug: Prefetching freebsd resources for package
debug: Puppet::Type::Package::ProviderFreebsd: Executing '/usr/sbin/pkg_info -aoQ'
debug: Puppet::Type::Package::ProviderFreebsd: Executing '/usr/sbin/pkg_info -aoQ'
debug: Package: sysutils/tmux: origin => {:port_category=>"sysutils", :port_name=>"tmux"}
debug: Package: sysutils/tmux: source => #<URI::HTTP:0x805cf55f0 URL:http://packages.blogreen.org/>
debug: Fetching INDEX: #<URI::HTTP:0x805cf4290 URL:http://packages.blogreen.org/INDEX.bz2>
err: /Stage[main]/XXXX/Package[sysutils/tmux]/ensure: change from absent to present failed: Could not set 'present on ensure: can't convert nil into String at /usr/local/etc/puppet/manifests/site.pp:27
--------- [end of failure details] ---------

The file /usr/local/lib/ruby/site_ruby/1.8/puppet/provider/package/freebsd.rb
is patched from the origninal one by the port, but the error is tied into it.
Relevant code:

------ [beginning of failing code] ------
 77         Puppet.debug "Fetching INDEX: #{uri.inspect}"
 78         begin
 79           open(uri, "r") do |f|
 80             Bzip2::Reader.open(f.path) do |f|
 81               while (line = f.gets)
 82                 fields = line.split("|")
 83                 pkg_info = self.class.parse_pkg_string(fields[0])
 84                 origin = self.class.parse_origin(fields[1])
 85                 @@ports_index[origin] = pkg_info
 86               end
 87             end
 88           end
 89         rescue IOError, OpenURI::HTTPError, Net::FTPError
 90           @@ports_index = nil
 91           raise Puppet::Error.new "Could not fetch ports INDEX: #{$!}"
 92         end
--------- [end of failing code] ---------

From IRB, the object provided by open at line 79 has no #path::

------ [beginning of failing code] ------
irb(main):001:0> require 'open-uri'
=> true
irb(main):002:0> open("http://packages.blogreen.org/INDEX-9.bz2", "r") do |f|
irb(main):003:1* f.path
irb(main):004:1> end
=> nil
--------- [end of failing code] ---------

Maybe this is a regression or something...  AFAICR, this code used to work a
while ago.

Fix: Bzip2::Reader.open seems to accept URIs, so we can just apply this change:

------ [beginning of fix] ------
How-To-Repeat: 
Try to install a package.