When I install GNS3 from ports, the file qemuwrapper.py is being installed in two localtions. I see no reason to do it. There are: {$PREFIX}/bin/qemuwrapper.py {$PREFIX}/libexec/qemuwrapper.py Both files are the the same. Using only the second path is more propriate. The second problem is, that GNS3 can not be started in background as it is preferred. When I try run GNS3 (gns3 &), there is shown a number of process, and than there is appeard communicate: [1] + suspended (tty output) gns3.
Maintainer of emulators/gns3, Please note that PR ports/169489 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/169489 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Hi, You've right regarding the bin/qemuwrapper.py file: I've remove this duplicate file in the attached patch. Regarding the problem of starting GNS3 as a background process: I have no idea about how to fix this problem (I'm not a python coder). I've asked some help on the GNS3 forum here: http://forum.gns3.net/topic5058.html Regards, Olivier
Responsible Changed From-To: freebsd-ports-bugs->ak I'll take it.
Hi, Olivier Why do you install man page conditionally? I think that Makefile can be simplified by options removal without loss of functionality. -- Alex
On Sat, Jun 30, 2012 at 12:39 PM, Alex Kozlov <ak@freebsd.org> wrote: > Hi, Olivier > > Why do you install man page conditionally? I think that Makefile > can be simplified by options removal without loss of functionality. Hi Alex, I've added this condition for trying to respect the knobs MANPAGES:=A0If someone wants to setup "GNS3_unset =3D MANPAGES", I would to avoid installing the manpage. Do you think that without this "conditional install" it will still respect this KNOBS ? Regards, Olivier
On Sat, Jun 30, 2012 at 10:24:57PM +0200, Olivier Cochard-Labbé wrote: > On Sat, Jun 30, 2012 at 12:39 PM, Alex Kozlov <ak@freebsd.org> wrote: > > Hi, Olivier > > > > Why do you install man page conditionally? I think that Makefile > > can be simplified by options removal without loss of functionality. > > Hi Alex, > > I've added this condition for trying to respect the knobs MANPAGES: If > someone wants to setup "GNS3_unset = MANPAGES", I would to avoid > installing the manpage. I guess you mean NO_INSTALL_MANPAGES (see ports/Mk/bsd.port.mk for description). It's not necessary to implement this knob, but if you going to do so don't use custom name, or hide MAN1 under condition. Also there is no need to include both bsd.port.options.mk and bsd.port.pre.mk, usually former is enough. > Do you think that without this "conditional install" it will still > respect this KNOBS ? No, at least not until stagedir (http://wiki.freebsd.org/ports/StageDir) support will be committed. What is your opinion about issue with starting gns3 in the background? -- Alex
On Sun, Jul 1, 2012 at 12:09 PM, Alex Kozlov <ak@freebsd.org> wrote: > On Sat, Jun 30, 2012 at 10:24:57PM +0200, Olivier Cochard-Labb=E9 wrote: >> I've added this condition for trying to respect the knobs MANPAGES:=A0If >> someone wants to setup "GNS3_unset =3D MANPAGES", I would to avoid >> installing the manpage. > I guess you mean NO_INSTALL_MANPAGES (see ports/Mk/bsd.port.mk for > description). It's not necessary to implement this knob, but if > you going to do so don't use custom name, or hide MAN1 under > condition. Also there is no need to include both bsd.port.options.mk > and bsd.port.pre.mk, usually former is enough. No, I really mean "GNS3_unset =3D MANPAGES" or "OPTIONS_UNSET=3D MANPAGES" because I'm trying to follow the new optionsNG framework: http://wiki.freebsd.org/Ports/Options/OptionsNG http://www.freebsd.org/doc/en/books/porters-handbook/makefile-options.html and I try to respect the KNOBS "MANPAGES" for following the generic KNOBS t= oo: http://www.freebsd.org/cgi/cvsweb.cgi/ports/KNOBS?rev=3DHEAD&content-type= =3Dtext/x-cvsweb-markup Should I create a new patch, or can you remove the "included <bsd.port.options.mk>" by yourself ? > What is your opinion about issue with starting gns3 in the background? I've installed Ubuntu Linux and gns3 on a VM, and I didn't have this problem on Linux. Because I didn't touch the original gns3 python code, it's perhaps a python bug under FreeBSD: I don't know how to solve this problem, even if as a graphical tool, it's a strange idea to start it in the background. Regars, Olivier
On Sun, Jul 01, 2012 at 04:17:07PM +0200, Olivier Cochard-Labbé wrote: > On Sun, Jul 1, 2012 at 12:09 PM, Alex Kozlov <ak@freebsd.org> wrote: > > On Sat, Jun 30, 2012 at 10:24:57PM +0200, Olivier Cochard-Labbé wrote: > >> I've added this condition for trying to respect the knobs MANPAGES: If > >> someone wants to setup "GNS3_unset = MANPAGES", I would to avoid > >> installing the manpage. > > I guess you mean NO_INSTALL_MANPAGES (see ports/Mk/bsd.port.mk for > > description). It's not necessary to implement this knob, but if > > you going to do so don't use custom name, or hide MAN1 under > > condition. Also there is no need to include both bsd.port.options.mk > > and bsd.port.pre.mk, usually former is enough. > No, I really mean "GNS3_unset = MANPAGES" or "OPTIONS_UNSET= MANPAGES" > because I'm trying to follow the new optionsNG framework: > http://wiki.freebsd.org/Ports/Options/OptionsNG > http://www.freebsd.org/doc/en/books/porters-handbook/makefile-options.html > > and I try to respect the KNOBS "MANPAGES" for following the generic KNOBS too: > http://www.freebsd.org/cgi/cvsweb.cgi/ports/KNOBS?rev=HEAD&content-type=text/x-cvsweb-markup Only 6 ports use MANPAGES against 156 ports for NO_INSTALL_MANPAGES, so I don't think that it widely used or known knob. On other hand it doesn't cause any harm, so if you wish so, I will commit this update with minimal changes like removal of bsd.port.pre.mk, moving MAN1 under MANPAGES condition and changing MANPREFIX to MAN1PREFIX. > Should I create a new patch, or can you remove the "included > <bsd.port.options.mk>" by yourself ? No need. > > What is your opinion about issue with starting gns3 in the background? > I've installed Ubuntu Linux and gns3 on a VM, and I didn't have this > problem on Linux. > Because I didn't touch the original gns3 python code, it's perhaps a > python bug under FreeBSD: I don't know how to solve this problem, even > if as a graphical tool, it's a strange idea to start it in the > background. So second issue falls into WONTFIX category and I can close this pr after resolving first? -- Alex
On Tue, Jul 3, 2012 at 4:38 PM, Alex Kozlov <ak@freebsd.org> wrote: > On other hand it doesn't cause any harm, so if you wish so, I will commit this > update with minimal changes like removal of bsd.port.pre.mk, moving MAN1 > under MANPAGES condition and changing MANPREFIX to MAN1PREFIX. Great ! > So second issue falls into WONTFIX category and I can close this pr after > resolving first? Yes you can close it as WONTFIX. Thanks, Olivier
ak 2012-07-03 17:41:29 UTC FreeBSD ports repository Modified files: emulators/gns3 Makefile pkg-plist Log: - Remove unneeded wrapper from ${PREFIX}/bin PR: ports/169489 Submitted by: Adrian Holota <holotaa@iem.pw.edu.pl> Approved by: Olivier Cochard-Labbe <olivier@cochard.me> (maintainer) Revision Changes Path 1.16 +6 -6 ports/emulators/gns3/Makefile 1.6 +0 -1 ports/emulators/gns3/pkg-plist _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Committed, with minor changes. Thanks!