Bug 169807 - multimedia/gnome-mplayer fails to build with NOTIFY support
Summary: multimedia/gnome-mplayer fails to build with NOTIFY support
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Stefan Walter
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-12 16:10 UTC by c.kworr
Modified: 2013-05-13 17:20 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description c.kworr 2012-07-12 16:10:02 UTC
When building port with NOTIFY this happens:

rm -f libgmlib.a
ar cru libgmlib.a libgmlib_a-gm_file.o  libgmlib_a-gm_parse.o  libgmlib_a-gm_pref_store.o  libgmlib_a-gm_strfuncs.o 
ranlib libgmlib.a
clang -DHAVE_CONFIG_H -I. -I.. -DPACKAGE_LOCALE_DIR=\""/usr/local/share/locale"\"  -DPACKAGE_SRC_DIR=\""."\"  -DPACKAGE_DATA_DIR=\""/usr/local/share"\"  -I../pixmaps  -D_THREAD_SAFE -D_R
EENTRANT -I/usr/local/include/gtk-2.0 -I/usr/local/include/atk-1.0 -I/usr/local/include/cairo -I/usr/local/include/gdk-pixbuf-2.0 -I/usr/local/include/pango-1.0 -I/usr/local/include/gio-
unix-2.0/ -I/usr/local/include -I/usr/local/include/glib-2.0 -I/usr/local/include/pixman-1 -I/usr/local/include/freetype2 -I/usr/local/include/libpng15 -I/usr/local/include/libdrm  -D_RE
ENTRANT -I/usr/local/include/glib-2.0  -D_REENTRANT -I/usr/local/include/dbus-1.0 -I/usr/local/include/dbus-1.0/include -I/usr/local/include/glib-2.0  -DORBIT2=1 -D_REENTRANT -I/usr/local/include/gconf/2 -I/usr/local/include/orbit-2.0 -I/usr/local/include/glib-2.0    -D_REENTRANT -I/usr/local/include -I/usr/local/include/gdk-pixbuf-2.0 -I/usr/local/include/glib-2.0 -I/usr/local/include/libpng15      -D_THREAD_SAFE -I/usr/local/include   -I/usr/local/include -Walclang -DHAVE_CONFIG_H -I. -I.. -DPACKAGE_LOCALE_DIR=\""/usr/local/share/locale"\"  -DPACKAGE_SRC_DIR=\""."\"  -DPACKAGE_DATA_DIR=\""/usr/local/share"\"  -I../pixmaps  -D_THREAD_SAFE -D_REENTRANT -I/usr/local/include/gtk-2.0 -I/usr/local/include/atk-1.0 -I/usr/local/include/cairo -I/usr/local/include/gdk-pixbuf-2.0 -I/usr/local/include/pango-1.0 -I/usr/local/include/gio-unix-2.0/ -I/usr/local/include -I/usr/local/include/glib-2.0 -I/usr/local/include/pixman-1 -I/usr/local/include/freetype2 -I/usr/local/include/libpng15 -I/usr/l
 ocal/include/libdrm  -D_REENTRANT -I/usr/local/include/glib-2.0  -D_REENTRANT -I/usr/local/include/dbus-1.0 -I/usr/local/include/dbus-1.0/include -I/usr/local/include/glib-2.0  -DORBIT2=1 -D_REENTRANT -I/usr/local/include/gconf/2 -I/usr/local/include/orbit-2.0 -I/usr/local/include/glib-2.0    -D_REENTRANT -I/usr/local/include -I/usr/local/include/gdk-pixbuf-2.0 -I/usr/local/include/glib-2.0 -I/usr/local/include/libpng15      -D_THREAD_SAFE -I/usr/local/include   -I/usr/local/include -Wall -g -DGTK2_12_ENABLED  -DGLIB2_14_ENABLED  -DGIO_ENABLED    -DHAVE_GCONF  -DNOTIFY_ENABLED     -O2 -pipe -march=core2 -fno-strict-aliasing -MT gui.o -MD -MP -MF .deps/gui.Tpo -c -o gui.o gui.c
l -g -DGTK2_12_ENABLED  -DGLIB2_14_ENABLED  -DGIO_ENABLED    -DHAVE_GCONF  -DNOTIFY_ENABLED     -O2 -pipe -march=core2 -fno-strict-aliasing -MT playlist.o -MD -MP -MF .deps/playlist.Tpo 
-c -o playlist.o playlist.c
gui.c:475:58: error: too many arguments to function call, expected 3, have 4
                                        "gnome-mplayer", NULL);
                                                         ^~~~
/usr/include/sys/_null.h:32:14: note: expanded from macro 'NULL'
#define NULL    ((void *)0)
                ^~~~~~~~~~~
/usr/local/include/libnotify/notification.h:114:1: note: 'notify_notification_new' declared here
NotifyNotification *notify_notification_new                  (const char         *summary,
^
gui.c:478:17: warning: implicit declaration of function 'notify_notification_attach_to_status_icon' is invalid in C99 [-Wimplicit-function-declaration]
                notify_notification_attach_to_status_icon(notification, status_icon);
                ^
1 warning and 1 error generated.
mv -f .deps/playlist.Tpo .deps/playlist.Po

It seems that patch which enables NOTIFY support is not correct anymore.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-07-12 16:10:16 UTC
Responsible Changed
From-To: freebsd-ports-bugs->avl

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2013-03-10 02:48:56 UTC
Responsible Changed
From-To: avl->freebsd-ports-bugs

Maintainer was reset.
Comment 3 Stefan Walter freebsd_committer freebsd_triage 2013-05-01 10:13:36 UTC
Hello Volodymyr,

unfortunately, there hasn't been any activity with your problem report on
multimedia/gnome-mplayer (see [1]) for a while. In the meantime, the port
has been updated multiple times, and building it worked fine with me. Does
the problem still exist with you, or should this PR be closed?

Best regards,
Stefan

[1]: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/169807
Comment 4 Stefan Walter freebsd_committer freebsd_triage 2013-05-01 10:13:46 UTC
State Changed
From-To: open->feedback

Awaiting submitter's feedback. 


Comment 5 Stefan Walter freebsd_committer freebsd_triage 2013-05-01 10:13:46 UTC
Responsible Changed
From-To: freebsd-ports-bugs->stefan

Track this while waiting for submitter's feedback.
Comment 6 c.kworr 2013-05-04 07:05:54 UTC
01.05.2013 12:13, Stefan Walter:
> Hello Volodymyr,
>
> unfortunately, there hasn't been any activity with your problem report on
> multimedia/gnome-mplayer (see [1]) for a while. In the meantime, the port
> has been updated multiple times, and building it worked fine with me. Does
> the problem still exist with you, or should this PR be closed?

There's still problems with options (GIO GTK3 NLS NOTIFY):

configure: WARNING: unrecognized options: --enable-nls
===>  Building for gnome-mplayer-1.0.8
"Makefile", line 1071: Need an operator
"Makefile", line 1074: Need an operator
make: fatal errors encountered -- cannot continue
*** [do-build] Error code 1

> [1]: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/169807

-- 
Sphinx of black quartz judge my vow.
Comment 7 Stefan Walter freebsd_committer freebsd_triage 2013-05-05 09:57:41 UTC
Volodymyr Kostyrko, 04.05.13, 08:05h CEST:

> There's still problems with options (GIO GTK3 NLS NOTIFY):
> 
> configure: WARNING: unrecognized options: --enable-nls
> ===>  Building for gnome-mplayer-1.0.8
> "Makefile", line 1071: Need an operator
> "Makefile", line 1074: Need an operator
> make: fatal errors encountered -- cannot continue
> *** [do-build] Error code 1

Not with me - it builds fine with that OPTIONS selection - and with any
other selection I tried, too. (I do get the warning from configure about
"--enable-nls", but that doesn't seem to cause a problem.) It seems to be
a local problem with your system.

"Need an operator" usually indicates either a problem with the Makefile or
that you're running the wrong "make". Can you verify that you are using a
clean, unmodified(!) and up-to-date version of the
multimedia/gnome-mplayer port? Can you also verify that you are running
FreeBSD's own /usr/bin/make, not gmake or something else?

Best regards,
Stefan
Comment 8 c.kworr 2013-05-12 20:58:15 UTC
2013/5/5 Stefan Walter <stefan@freebsd.org>

> Volodymyr Kostyrko, 04.05.13, 08:05h CEST:
>
> > There's still problems with options (GIO GTK3 NLS NOTIFY):
> >
> > configure: WARNING: unrecognized options: --enable-nls
> > ===>  Building for gnome-mplayer-1.0.8
> > "Makefile", line 1071: Need an operator
> > "Makefile", line 1074: Need an operator
> > make: fatal errors encountered -- cannot continue
> > *** [do-build] Error code 1
>
> Not with me - it builds fine with that OPTIONS selection - and with any
> other selection I tried, too. (I do get the warning from configure about
> "--enable-nls", but that doesn't seem to cause a problem.) It seems to be
> a local problem with your system.
>
> "Need an operator" usually indicates either a problem with the Makefile or
> that you're running the wrong "make". Can you verify that you are using a
> clean, unmodified(!) and up-to-date version of the
> multimedia/gnome-mplayer port? Can you also verify that you are running
> FreeBSD's own /usr/bin/make, not gmake or something else?
>

Sorry for delays. I was just inspecting the port on whether I would use it
anyway. Right now I'm returning to this thread from time to time only
because I started that rant.

First. Makefile in work dir has this part upon generation:

ifdef gsettings_ENUM_NAMESPACE
$(gsettings__enum_file): $(gsettings_ENUM_FILES)
  $(AM_V_GEN) glib-mkenums --comments '<!-- @comment@ -->' --fhead
"<schemalist>" --vhead "  <@type@ id='$(gsettings_ENUM_NAMESPACE).@EnumName@'>"
--vprod "    <value nick='@valuenick@' value='@valuenum@'/>" --vtail "
</@type@>" --ftail "</schemalist>" $^ > $@.tmp && mv $@.tmp $@
endif

This is GNU make syntax yet port doesn't state that GNU make should be used.

===>  Building for gnome-mplayer-1.0.8
"Makefile", line 1071: Need an operator
"Makefile", line 1074: Need an operator
make: fatal errors encountered -- cannot continue

This is BSD make error, when I add USE_GMAKE=yes to the port Makefile the
port compiles fine for me and even works.

-- 
Sphinx of black quartz judge my vow.
Comment 9 dfilter service freebsd_committer freebsd_triage 2013-05-13 17:11:16 UTC
Author: stefan
Date: Mon May 13 16:11:09 2013
New Revision: 318119
URL: http://svnweb.freebsd.org/changeset/ports/318119

Log:
  Add missing USE_GMAKE.
  
  PR:		169807
  Submitted by:	Volodymyr Kostyrko <c.kworr@gmail.com>

Modified:
  head/multimedia/gnome-mplayer/Makefile

Modified: head/multimedia/gnome-mplayer/Makefile
==============================================================================
--- head/multimedia/gnome-mplayer/Makefile	Mon May 13 16:02:31 2013	(r318118)
+++ head/multimedia/gnome-mplayer/Makefile	Mon May 13 16:11:09 2013	(r318119)
@@ -24,6 +24,7 @@ NAUPLUG_DESC=	Enable Nautilus plugin
 MAKE_JOBS_SAFE=	yes
 
 GNU_CONFIGURE=	yes
+USE_GMAKE=	yes
 USE_GNOME=	glib20
 USE_XORG=	x11 xscrnsaver
 INSTALLS_ICONS=	yes
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 10 Stefan Walter freebsd_committer freebsd_triage 2013-05-13 17:13:49 UTC
Hi Volodymyr,

Volodymyr Kostyrko, 12.05.13, 21:58h CEST:

> This is BSD make error, when I add USE_GMAKE=yes to the port Makefile the
> port compiles fine for me and even works.

I didn't look at the generated Makefile. It's interesting that it works
with me (and the redports.org tinderbox) without USE_GMAKE=yes. However, I
have added it to the Makefile in the tree now. Thanks for the feedback!

Best regards,
Stefan
Comment 11 Stefan Walter freebsd_committer freebsd_triage 2013-05-13 17:14:07 UTC
State Changed
From-To: feedback->closed

Fix committed, thanks!