Bug 169855 - [NEW PORT] net-mgmt/p0f2: Passive OS fingerprinting tool
Summary: [NEW PORT] net-mgmt/p0f2: Passive OS fingerprinting tool
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Michael Scheidell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-14 14:20 UTC by Denis Pokataev
Modified: 2012-07-30 19:20 UTC (History)
1 user (show)

See Also:


Attachments
.shar (3.28 KB, text/plain)
2012-07-14 14:20 UTC, Denis Pokataev
no flags Details
patch-p0f.port.diff (6.70 KB, patch)
2012-07-30 12:55 UTC, Denis Pokataev
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Denis Pokataev 2012-07-14 14:20:01 UTC
Current port net-mgmt/p0f has been switched to 3 version of p0f,
but it still has too small fingerprints database.

p0f version 2 gives better results then 3,
especially when used with updated databases like
https://tools.netsa.cert.org/confluence/display/tt/p0f+fingerprints

We are using version 2, and I'm pretty sure that we are not the only ones.
So, I'm sure that until p0f3 becomes comparable with p0f2, it is better to have both
in ports collection.

Thanks in advance.

Diff with last p0f-2* port:
change PORTNAME to p0f2
bump PORTREVISION
add CONFLICTS
add pkg-plist

Generated with FreeBSD Port Tools 0.99_6 (mode: new)
Comment 1 Michael Scheidell freebsd_committer freebsd_triage 2012-07-26 13:00:50 UTC
Thank you for your ports submission and continued support of FreeBSD 
(and on a personal note, I stopped using p0f 3.x due to its small database)

Several issues here:
#1, we can't put in a new port without a maintainer.
#2, this really needs to be a 'repocopy net-mgmt/p0f -> net-mgmt/p0f2', 
not a 'new port'
#3, the pr submission should be the diffs to take 'net-mgmt/p0f2' 
forward (including your name as maintainer)
#4, don't bump portrevision, this is a new port, portrevision like 
should be removed

make those changes, and someone will test and commit.

-- 
Michael Scheidell, CTO
 >*| * SECNAP Network Security Corporation
d: +1.561.948.2259
w: http://people.freebsd.org/~scheidell
Comment 2 Denis Pokataev 2012-07-30 12:55:42 UTC
On Thu, Jul 26, 2012 at 4:00 PM, Michael Scheidell
<scheidell@freebsd.org> wrote:
> Thank you for your ports submission and continued support of FreeBSD (and on
> a personal note, I stopped using p0f 3.x due to its small database)
>
> Several issues here:
> #1, we can't put in a new port without a maintainer.
> #2, this really needs to be a 'repocopy net-mgmt/p0f -> net-mgmt/p0f2', not
> a 'new port'
> #3, the pr submission should be the diffs to take 'net-mgmt/p0f2' forward
> (including your name as maintainer)
> #4, don't bump portrevision, this is a new port, portrevision like should be
> removed
>
> make those changes, and someone will test and commit.

Hope I got you right, diff is in attachment.
Or should I create new PR?

>
> --
> Michael Scheidell, CTO
>> | SECNAP Network Security Corporation
> d: +1.561.948.2259
> w: http://people.freebsd.org/~scheidell



-- 
Regards, Denis.
Comment 3 Michael Scheidell freebsd_committer freebsd_triage 2012-07-30 18:36:36 UTC
Responsible Changed
From-To: freebsd-ports-bugs->scheidell

I'll take it.
Comment 4 dfilter service freebsd_committer freebsd_triage 2012-07-30 19:17:09 UTC
Author: scheidell
Date: Mon Jul 30 18:16:59 2012
New Revision: 301727
URL: http://svn.freebsd.org/changeset/ports/301727

Log:
  - New port: p0f2 Passive OS fingerprinting tool p0f version 2 gives better 3
  
  PR:		ports/169855
  Submitted by:	Denis Pokataev <catone@cpan.org>

Added:
  head/net-mgmt/p0f2/
     - copied from r301725, head/net-mgmt/p0f/
  head/net-mgmt/p0f2/pkg-plist   (contents, props changed)
Deleted:
  head/net-mgmt/p0f2/files/
Modified:
  head/net-mgmt/Makefile   (contents, props changed)
  head/net-mgmt/p0f2/Makefile   (contents, props changed)
  head/net-mgmt/p0f2/distinfo   (contents, props changed)

Modified: head/net-mgmt/Makefile
==============================================================================
--- head/net-mgmt/Makefile	Mon Jul 30 17:47:53 2012	(r301726)
+++ head/net-mgmt/Makefile	Mon Jul 30 18:16:59 2012	(r301727)
@@ -190,6 +190,7 @@
     SUBDIR += openvmps
     SUBDIR += ourmon
     SUBDIR += p0f
+    SUBDIR += p0f2
     SUBDIR += p5-AnyEvent-SNMP
     SUBDIR += p5-Cflow
     SUBDIR += p5-Cisco-Reconfig

Modified: head/net-mgmt/p0f2/Makefile
==============================================================================
--- head/net-mgmt/p0f/Makefile	Mon Jul 30 17:24:18 2012	(r301725)
+++ head/net-mgmt/p0f2/Makefile	Mon Jul 30 18:16:59 2012	(r301727)
@@ -1,45 +1,49 @@
-# New ports collection makefile for:	p0f
-# Date created:				2000-06-12
-# Whom:					Trevor Johnson
+# New ports collection makefile for:	p0f2
+# Date created:				2012-07-30
+# Whom:					Denis Pokataev <catone@cpan.org>
 #
 # $FreeBSD$
 #
 
-PORTNAME=	p0f
-PORTVERSION=	3.05b
+PORTNAME=	p0f2
+PORTVERSION=	2.0.8
 CATEGORIES=	net-mgmt security
-MASTER_SITES=	http://lcamtuf.coredump.cx/p0f3/releases/ \
-		http://fossies.org/unix/privat/
+MASTER_SITES=	http://lcamtuf.coredump.cx/p0f/ \
+		http://farrokhi.net/distfiles/
+DISTNAME=	p0f-${DISTVERSION}
 EXTRACT_SUFX=	.tgz
 
-MAINTAINER=	fbsd-ports@opsec.eu
+MAINTAINER=	catone@cpan.org
 COMMENT=	Passive OS fingerprinting tool
 
-LICENSE=	LGPL21
-LICENSE_FILE=	${WRKSRC}/docs/COPYING
+CONFLICTS=	p0f-3.*
 
-PLIST_FILES=	bin/p0f bin/p0f-client bin/p0f-sendsyn \
-		bin/p0f-sendsyn6 etc/p0f.fp
-PORTDOCS=	COPYING ChangeLog README TODO existential-notes.txt \
-		extra-sigs.txt
-
-MAKE_JOBS_SAFE=	yes
-MAKE_ARGS+=	CC="${CC}" CFLAGS="${CFLAGS}"
+USE_GMAKE=	yes
+ALL_TARGET=	all p0fq tools
+PORTDOCS=	COPYING CREDITS ChangeLog KNOWN_BUGS README TODO win-memleak.txt
+MAN1=		p0f.1
+WRKSRC=		${WRKDIR}/p0f
 
 post-patch:
-	@${REINPLACE_CMD} -e 's|/etc|${PREFIX}/etc|g' ${WRKSRC}/README
-	@${REINPLACE_CMD} -e 's|p0f.fp|${PREFIX}/etc/p0f.fp|g' ${WRKSRC}/config.h
+.for f in config.h doc/README
+	@${REINPLACE_CMD} -e 's|/etc|${PREFIX}/etc|g' ${WRKSRC}/${f}
+.endfor
 
 do-install:
-.for ii in p0f tools/p0f-client tools/p0f-sendsyn tools/p0f-sendsyn6
+.for ii in p0f test/p0fq test/sendack test/sendack2 test/sendsyn
 	${INSTALL_PROGRAM} ${WRKSRC}/${ii} ${PREFIX}/bin
 .endfor
-	${INSTALL_DATA} ${WRKSRC}/p0f.fp ${PREFIX}/etc/
+	${INSTALL_SCRIPT} ${WRKSRC}/p0frep ${PREFIX}/bin
+	${MKDIR} ${PREFIX}/etc/p0f
+.for ii in . a. o. r.
+	${INSTALL_DATA} ${WRKSRC}/p0f${ii}fp ${PREFIX}/etc/p0f
+.endfor
+	${INSTALL_MAN} ${WRKSRC}/${MAN1} ${MANPREFIX}/man/man1
 
 .if !defined(NOPORTDOCS)
 	${MKDIR} ${DOCSDIR}
 .for ii in ${PORTDOCS}
-	${INSTALL_DATA} ${WRKSRC}/docs/${ii} ${DOCSDIR}
+	${INSTALL_DATA} ${WRKSRC}/doc/${ii} ${DOCSDIR}
 .endfor
 .endif
 

Modified: head/net-mgmt/p0f2/distinfo
==============================================================================
--- head/net-mgmt/p0f/distinfo	Mon Jul 30 17:24:18 2012	(r301725)
+++ head/net-mgmt/p0f2/distinfo	Mon Jul 30 18:16:59 2012	(r301727)
@@ -1,2 +1,2 @@
-SHA256 (p0f-3.05b.tgz) = c4663e669fe43ef4f36f1f5935c4fab571ef19838c4aed90cf3b8bc2264f6b3b
-SIZE (p0f-3.05b.tgz) = 91902
+SHA256 (p0f-2.0.8.tgz) = 6c4d8745f04e59f2ba68d56fd1554551592f08a0497c9fc21b84498f47d1aee0
+SIZE (p0f-2.0.8.tgz) = 136877

Added: head/net-mgmt/p0f2/pkg-plist
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/net-mgmt/p0f2/pkg-plist	Mon Jul 30 18:16:59 2012	(r301727)
@@ -0,0 +1,11 @@
+bin/p0f
+bin/p0fq
+bin/p0frep
+bin/sendack
+bin/sendack2
+bin/sendsyn
+etc/p0f/p0f.fp
+etc/p0f/p0fa.fp
+etc/p0f/p0fo.fp
+etc/p0f/p0fr.fp
+@dirrmtry etc/p0f
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 5 Michael Scheidell freebsd_committer freebsd_triage 2012-07-30 19:17:18 UTC
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!