Bug 169904 - [MAINTAINER] audio/libmusicbrainz4: Use LATEST_LINK
Summary: [MAINTAINER] audio/libmusicbrainz4: Use LATEST_LINK
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Jase Thew
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-16 11:20 UTC by Jason E. Hale
Modified: 2012-07-27 14:35 UTC (History)
0 users

See Also:


Attachments
2012-07-16-libmusicbrainz4.diff (848 bytes, patch)
2012-07-16 11:20 UTC, Jason E. Hale
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jason E. Hale 2012-07-16 11:20:08 UTC
- Use LATEST_LINK instead of defining the major version in PORTNAME

How-To-Repeat: - Use attached diff
Comment 1 Jase Thew freebsd_committer freebsd_triage 2012-07-17 11:57:40 UTC
Responsible Changed
From-To: freebsd-ports-bugs->jase

I'll take it.
Comment 2 Jason E. Hale 2012-07-27 09:59:47 UTC
Here is an updated patch to use the new USE_PKGCONFIG macro.

--- 2012-07-27-libmusicbrainz4.diff begins here ---
Index: Makefile
===================================================================
--- Makefile	(revision 301592)
+++ Makefile	(working copy)
@@ -5,11 +5,11 @@
 # $FreeBSD$
 #
 
-PORTNAME=	libmusicbrainz4
+PORTNAME=	libmusicbrainz
 PORTVERSION=	4.0.3
+PORTREVISION=	1
 CATEGORIES=	audio
-MASTER_SITES=	https://cloud.github.com/downloads/metabrainz/${PORTNAME:S/4//}/
-DISTNAME=	${PORTNAME:S/4//}-${PORTVERSION}
+MASTER_SITES=	https://cloud.github.com/downloads/metabrainz/${PORTNAME}/
 
 MAINTAINER=	bsdkaffee@gmail.com
 COMMENT=	MusicBrainz client library for audio metadata lookup
@@ -18,8 +18,10 @@
 
 LIB_DEPENDS=	neon:${PORTSDIR}/www/neon29
 
+LATEST_LINK=	${PORTNAME}4
+
 USE_CMAKE=	yes
-USE_GNOME=	pkgconfig
+USE_PKGCONFIG=	yes
 USE_LDCONFIG=	yes
 
 MAKE_JOBS_SAFE=	yes
--- 2012-07-27-libmusicbrainz4.diff ends here ---
Comment 3 dfilter service freebsd_committer freebsd_triage 2012-07-27 14:29:12 UTC
Author: makc
Date: Fri Jul 27 13:28:58 2012
New Revision: 301615
URL: http://svn.freebsd.org/changeset/ports/301615

Log:
  - Use LATEST_LINK instead of defining the version in PORTNAME
  
  - while I'm here, respect LOCALBASE and thus remove needless dependency
    on pkg-config. pkg-config is often used by cmake as auxiliary tool
    to populate search paths. Until stuff is located at standard location,
    there is no need for pkg-config utility. [1]
  
  PR:		ports/169904
  Submitted by:	Jason E. Hale (maintainer)
  Approved by:	maintainer via irc [1]

Modified:
  head/audio/libmusicbrainz4/Makefile   (contents, props changed)

Modified: head/audio/libmusicbrainz4/Makefile
==============================================================================
--- head/audio/libmusicbrainz4/Makefile	Fri Jul 27 13:28:20 2012	(r301614)
+++ head/audio/libmusicbrainz4/Makefile	Fri Jul 27 13:28:58 2012	(r301615)
@@ -5,11 +5,10 @@
 # $FreeBSD$
 #
 
-PORTNAME=	libmusicbrainz4
+PORTNAME=	libmusicbrainz
 PORTVERSION=	4.0.3
 CATEGORIES=	audio
-MASTER_SITES=	https://cloud.github.com/downloads/metabrainz/${PORTNAME:S/4//}/
-DISTNAME=	${PORTNAME:S/4//}-${PORTVERSION}
+MASTER_SITES=	https://cloud.github.com/downloads/metabrainz/${PORTNAME}/
 
 MAINTAINER=	bsdkaffee@gmail.com
 COMMENT=	MusicBrainz client library for audio metadata lookup
@@ -18,8 +17,9 @@ LICENSE=	LGPL21
 
 LIB_DEPENDS=	neon:${PORTSDIR}/www/neon29
 
+LATEST_LINK=	${PORTNAME}4
+
 USE_CMAKE=	yes
-USE_GNOME=	pkgconfig
 USE_LDCONFIG=	yes
 
 MAKE_JOBS_SAFE=	yes
@@ -27,5 +27,7 @@ MAKE_JOBS_SAFE=	yes
 post-patch:
 	${REINPLACE_CMD} -e '/pkgconfig/s|$${LIB_INSTALL_DIR}|libdata|' \
 		 ${WRKSRC}/CMakeLists.txt
+	${REINPLACE_CMD} -e 's|/usr/local|${LOCALBASE}|g' \
+		 ${WRKSRC}/cmake/modules/*.cmake
 
 .include <bsd.port.mk>
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 4 Max Brazhnikov freebsd_committer freebsd_triage 2012-07-27 14:35:49 UTC
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!