Bug 170059 - devel/arduino [patch] Fix missing menu icon
Summary: devel/arduino [patch] Fix missing menu icon
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Michael Scheidell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-22 06:30 UTC by Warren Block
Modified: 2012-07-27 14:00 UTC (History)
0 users

See Also:

Attachments
file.diff (2.03 KB, patch)
2012-07-22 06:30 UTC, Warren Block 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Warren Block freebsd_committer freebsd_triage 2012-07-22 06:30:04 UTC 
If devel/arduino was installed with the Docs option disabled, no icon was available for the desktop menu entry.

Fix: Apply patch.

Patch attached with submission follows:
How-To-Repeat: Turn off the Docs option, install devel/arduino, look in desktop menu under Development.  No Arduino icon is visible.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-07-22 06:30:21 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->wblock

Submitter is maintainer and has GNATS access (via the GNATS Auto Assign 
Tool)
Comment 2 Warren Block freebsd_committer freebsd_triage 2012-07-22 06:41:06 UTC 
Responsible Changed
From-To: wblock->freebsd-ports-bugs

Back to the ports committers.
Comment 3 Michael Scheidell freebsd_committer freebsd_triage 2012-07-26 13:28:13 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->scheidell

I'll take it.
Comment 4 dfilter service freebsd_committer freebsd_triage 2012-07-27 13:58:45 UTC 
Author: scheidell
Date: Fri Jul 27 12:58:30 2012
New Revision: 301609
URL: http://svn.freebsd.org/changeset/ports/301609

Log:
  - Fix missing menu icon
  - Bump PORTREVISION
  
  PR:		ports/170059
  Submitted by:	wblock@ (maintainer)

Modified:
  head/devel/arduino/Makefile
  head/devel/arduino/pkg-plist

Modified: head/devel/arduino/Makefile
==============================================================================
--- head/devel/arduino/Makefile	Fri Jul 27 12:53:31 2012	(r301608)
+++ head/devel/arduino/Makefile	Fri Jul 27 12:58:30 2012	(r301609)
@@ -5,6 +5,7 @@
 
 PORTNAME=	arduino
 PORTVERSION=	1.0.1
+PORTREVISION=	1
 PORTEPOCH=	1
 CATEGORIES=	devel java lang
 MASTER_SITES=	GOOGLE_CODE
@@ -30,7 +31,7 @@ SUB_LIST=	PORTNAME=${PORTNAME}
 REINPLACE_ARGS=	-i ""
 
 DESKTOP_ENTRIES=	"Arduino" "Arduino IDE" \
-			${PREFIX}/${PORTNAME}/reference/img/logo.png \
+			${PREFIX}/${PORTNAME}/logo.png \
 			"arduino" "Development;IDE;" "false"
 
 OPTIONS_DEFINE+=	DOCS EXAMPLES
@@ -60,6 +61,9 @@ post-patch:
 	@${RM} ${WRKSRC}/lib/RXTXcomm.jar
 	@${LN} -s ${JAVA_HOME}/lib/ext/RXTXcomm.jar ${WRKSRC}/lib/RXTXcomm.jar
 
+	@${MV} ${WRKSRC}/reference/img/logo.png ${WRKSRC}/
+	@${RM} -rf ${WRKSRC}/reference/img/
+
 .if empty(PORT_OPTIONS:MDOCS)
 	@${RM} -rf ${WRKSRC}/reference
 .endif

Modified: head/devel/arduino/pkg-plist
==============================================================================
--- head/devel/arduino/pkg-plist	Fri Jul 27 12:53:31 2012	(r301608)
+++ head/devel/arduino/pkg-plist	Fri Jul 27 12:58:30 2012	(r301609)
@@ -337,6 +337,7 @@ arduino/libraries/Wire/Wire.h
 arduino/libraries/Wire/keywords.txt
 arduino/libraries/Wire/utility/twi.c
 arduino/libraries/Wire/utility/twi.h
+arduino/logo.png
 %%REFDOCS%%arduino/reference/Abs.html
 %%REFDOCS%%arduino/reference/AnalogRead.html
 %%REFDOCS%%arduino/reference/AnalogReference.html
@@ -614,7 +615,6 @@ arduino/libraries/Wire/utility/twi.h
 %%REFDOCS%%arduino/reference/arduinoWide.css
 %%REFDOCS%%arduino/reference/arduinoWideRender.css
 %%REFDOCS%%arduino/reference/environment.html
-%%REFDOCS%%arduino/reference/img/logo.png
 %%REFDOCS%%arduino/reference/index.html
 arduino/revisions.txt
 arduino/tools/Mangler/make.sh
@@ -624,7 +624,6 @@ bin/arduino
 @dirrm arduino/tools/Mangler/src
 @dirrm arduino/tools/Mangler
 @dirrm arduino/tools
-%%REFDOCS%%@dirrm arduino/reference/img
 %%REFDOCS%%@dirrm arduino/reference
 @dirrm arduino/libraries/Wire/utility
 %%EXAMPLES%%@dirrm arduino/libraries/Wire/examples/slave_sender
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 5 Michael Scheidell freebsd_committer freebsd_triage 2012-07-27 13:59:09 UTC 
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!