Bug 170301 - [patch] misusage of PYTHON_SITELIBDIR (non-default PREFIX)
Summary: [patch] misusage of PYTHON_SITELIBDIR (non-default PREFIX)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Wesley Shields
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-31 23:50 UTC by Jan Beich
Modified: 2012-08-10 15:30 UTC (History)
0 users

See Also:


Attachments
python_prefix.diff (1.25 KB, patch)
2012-07-31 23:50 UTC, Jan Beich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2012-07-31 23:50:09 UTC
Python ports install into PYTHONPREFIX_SITELIBDIR, not PYTHON_SITELIBDIR.
The list is not complete, suggest a better regexp than

  $ find . -name 'Makefile*' -exec grep '^DATADIR.*PYTHON_SITELIBDIR'

How-To-Repeat: $ make install deinstall PREFIX=/tmp/aaa PKG_DBDIR=/tmp/pkg
$ find /tmp/aaa/ ! -type d
/tmp/aaa/lib/python2.7/site-packages/bugz/cli.py
/tmp/aaa/lib/python2.7/site-packages/bugz/bugzilla.py
/tmp/aaa/lib/python2.7/site-packages/bugz/config.py
/tmp/aaa/lib/python2.7/site-packages/bugz/__init__.py
[...]
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2012-08-01 04:52:26 UTC
State Changed
From-To: open->feedback

note that feedback has been requested from multiple maintainers.
Comment 2 Wesley Shields freebsd_committer freebsd_triage 2012-08-03 02:40:10 UTC
Responsible Changed
From-To: freebsd-ports-bugs->wxs

I'll take it.
Comment 3 Mark Linimon 2012-08-04 21:56:26 UTC
----- Forwarded message from Nicola Vitale <nivit@FreeBSD.org> -----

Date: Sat, 4 Aug 2012 14:34:48 +0200
From: Nicola Vitale <nivit@FreeBSD.org>
To: linimon@freebsd.org
Cc: crees@freebsd.org, jbeich@tormail.org, freebsd-ports-bugs@freebsd.org
Subject: Re: ports/170301: [patch] misusage of PYTHON_SITELIBDIR (non-default PREFIX)

> [2012/8/1  <linimon@freebsd.org>]
> Synopsis: [patch] misusage of PYTHON_SITELIBDIR (non-default PREFIX)
> note that feedback has been requested from multiple maintainers.

I approve the patch.

-- 
Nicola Vitale


----- End forwarded message -----
Comment 4 Chris Rees 2012-08-05 17:38:28 UTC
Looks just fine to me.

Chris
Comment 5 dfilter service freebsd_committer freebsd_triage 2012-08-10 15:20:37 UTC
Author: wxs
Date: Fri Aug 10 14:20:23 2012
New Revision: 302389
URL: http://svn.freebsd.org/changeset/ports/302389

Log:
  Use PYTHONPREFIX_SITELIBDIR.
  
  PR:		ports/170301
  Submitted by:	Jan Beich <jbeich@tormail.org>
  Approved by:	crees@, nivit@

Modified:
  head/devel/pybugz/Makefile   (contents, props changed)
  head/print/py-pyscript/Makefile   (contents, props changed)
  head/x11-toolkits/py-wax/Makefile   (contents, props changed)

Modified: head/devel/pybugz/Makefile
==============================================================================
--- head/devel/pybugz/Makefile	Fri Aug 10 14:15:36 2012	(r302388)
+++ head/devel/pybugz/Makefile	Fri Aug 10 14:20:23 2012	(r302389)
@@ -24,7 +24,7 @@ USE_PYTHON=	2.5+
 USE_PYDISTUTILS=yes
 
 PLIST_FILES=	bin/bugz
-DATADIR=	${PYTHON_SITELIBDIR}/bugz
+DATADIR=	${PYTHONPREFIX_SITELIBDIR}/bugz
 PORTDATA=	*
 
 .include <bsd.port.mk>

Modified: head/print/py-pyscript/Makefile
==============================================================================
--- head/print/py-pyscript/Makefile	Fri Aug 10 14:15:36 2012	(r302388)
+++ head/print/py-pyscript/Makefile	Fri Aug 10 14:20:23 2012	(r302389)
@@ -21,7 +21,7 @@ RUN_DEPENDS=	latex:${PORTSDIR}/print/teT
 USE_PYTHON=	yes
 USE_PYDISTUTILS=	yes
 
-DATADIR=	${PYTHON_SITELIBDIR}/${PORTNAME}
+DATADIR=	${PYTHONPREFIX_SITELIBDIR}/${PORTNAME}
 
 PYSCRIPT_EXAMPLES=	doc/examples/*.py
 PYSCRIPT_MANUAL=	doc/manual/pyscript.pdf

Modified: head/x11-toolkits/py-wax/Makefile
==============================================================================
--- head/x11-toolkits/py-wax/Makefile	Fri Aug 10 14:15:36 2012	(r302388)
+++ head/x11-toolkits/py-wax/Makefile	Fri Aug 10 14:20:23 2012	(r302389)
@@ -15,7 +15,7 @@ PKGNAMEPREFIX=	${PYTHON_PKGNAMEPREFIX}
 MAINTAINER=	nivit@FreeBSD.org
 COMMENT=	A user-friendly layer on top of wxPython
 
-RUN_DEPENDS=	${PYTHON_SITELIBDIR}/${WX_PYTHON_DIR}/wxPython/_wx.py:${PORTSDIR}/x11-toolkits/py-wxPython26
+RUN_DEPENDS=	${PYTHONPREFIX_SITELIBDIR}/${WX_PYTHON_DIR}/wxPython/_wx.py:${PORTSDIR}/x11-toolkits/py-wxPython26
 
 NO_BUILD=	yes
 USE_PYTHON=	yes
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 6 Wesley Shields freebsd_committer freebsd_triage 2012-08-10 15:20:48 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!