Bug 170453 - multimedia/ffmpeg uses devel/pkgconf but does not list it as build dependency
Summary: multimedia/ffmpeg uses devel/pkgconf but does not list it as build dependency
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Martin Matuska
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-07 15:40 UTC by Kimmo Paasiala
Modified: 2012-08-07 18:01 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Paasiala 2012-08-07 15:40:03 UTC 
multimedia/ffmpeg depends on devel/pkgconf for build but does not list it as a build dependency. If ffmpeg's dependencies are changed to depend on devel/pkgconf only on build time it's possible that build of ffmpeg fails on configure stage because devel/pkgconf is not installed because ffmpeg does not pull it in.

Fix: 

Use the new 'USE_PKGCONFIG=build' macro in the Makefile of multimedia/ffmpeg.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-08-07 15:40:13 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->mm

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2012-08-07 17:36:19 UTC 
Author: mm
Date: Tue Aug  7 16:36:04 2012
New Revision: 302246
URL: http://svn.freebsd.org/changeset/ports/302246

Log:
  Depend on pkgconfig on build stage
  
  PR:		ports/170453

Modified:
  head/multimedia/ffmpeg-011/Makefile
  head/multimedia/ffmpeg-devel/Makefile
  head/multimedia/ffmpeg/Makefile

Modified: head/multimedia/ffmpeg-011/Makefile
==============================================================================
--- head/multimedia/ffmpeg-011/Makefile	Tue Aug  7 16:12:15 2012	(r302245)
+++ head/multimedia/ffmpeg-011/Makefile	Tue Aug  7 16:36:04 2012	(r302246)
@@ -31,6 +31,7 @@ USE_GMAKE=	yes
 MAKE_JOBS_SAFE=	yes
 WANT_SDL=	yes
 USE_PERL5_BUILD=	yes
+USE_PKGCONFIG=	build
 
 OPTIONS_DEFINE=	AACPLUS ALSA AMR_NB AMR_WB ASS CDIO CELT DEBUG FAAC \
 		FFSERVER FONTCONFIG FREETYPE FREI0R GNUTLS GSM LAME \

Modified: head/multimedia/ffmpeg-devel/Makefile
==============================================================================
--- head/multimedia/ffmpeg-devel/Makefile	Tue Aug  7 16:12:15 2012	(r302245)
+++ head/multimedia/ffmpeg-devel/Makefile	Tue Aug  7 16:36:04 2012	(r302246)
@@ -40,6 +40,7 @@ USE_GMAKE=	yes
 MAKE_JOBS_SAFE=	yes
 WANT_SDL=	yes
 USE_PERL5_BUILD=	yes
+USE_PKGCONFIG=	build
 
 OPTIONS_DEFINE=	AACPLUS ALSA AMR_NB AMR_WB ASS CDIO CELT DEBUG FAAC \
 		FDK_AAC FFSERVER FONTCONFIG FREETYPE FREI0R GNUTLS GSM LAME \

Modified: head/multimedia/ffmpeg/Makefile
==============================================================================
--- head/multimedia/ffmpeg/Makefile	Tue Aug  7 16:12:15 2012	(r302245)
+++ head/multimedia/ffmpeg/Makefile	Tue Aug  7 16:36:04 2012	(r302246)
@@ -30,6 +30,7 @@ USE_GMAKE=	yes
 MAKE_JOBS_SAFE=	yes
 WANT_SDL=	yes
 USE_PERL5_BUILD=	yes
+USE_PKGCONFIG=	build
 
 OPTIONS_DEFINE=	AACPLUS ALSA AMR_NB AMR_WB CELT DEBUG DIRAC FAAC \
 		FFSERVER FREETYPE FREI0R GSM LAME OPENCV OPENJPEG \
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 3 Martin Matuska freebsd_committer freebsd_triage 2012-08-07 18:01:30 UTC 
State Changed
From-To: open->closed

Committed. Thanks!