Bug 170510 - [PATCH] astro/gpsd: Replace reference to -lpthread in .pc file
Summary: [PATCH] astro/gpsd: Replace reference to -lpthread in .pc file
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-09 17:50 UTC by Jason E. Hale
Modified: 2012-09-03 18:20 UTC (History)
1 user (show)

See Also:


Attachments
2012-08-09-gpsd.diff (590 bytes, patch)
2012-08-09 17:50 UTC, Jason E. Hale
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jason E. Hale 2012-08-09 17:50:01 UTC
- astro/gpsd references -lpthread in the pkgconfig file Qgpsmm.pc.in; this should
  be replaced with PTHREAD_LIBS

How-To-Repeat: - N/A
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2012-08-09 17:50:17 UTC
Responsible Changed
From-To: freebsd-ports-bugs->glebius

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Dmitry Marakasov freebsd_committer freebsd_triage 2012-09-03 17:46:26 UTC
Responsible Changed
From-To: glebius->amdmi3

I'll take it.
Comment 3 dfilter service freebsd_committer freebsd_triage 2012-09-03 18:13:07 UTC
Author: amdmi3
Date: Mon Sep  3 17:12:51 2012
New Revision: 303606
URL: http://svn.freebsd.org/changeset/ports/303606

Log:
  - Fix linking with pthreads
  - While here, add IGNORE for specific illegal options combination
  
  PR:		ports/170510
  Submitted by:	Jason E. Hale <bsdkaffee@gmail.com>
  Approved by:	glebius (maintainer)

Modified:
  head/astro/gpsd/Makefile

Modified: head/astro/gpsd/Makefile
==============================================================================
--- head/astro/gpsd/Makefile	Mon Sep  3 16:30:17 2012	(r303605)
+++ head/astro/gpsd/Makefile	Mon Sep  3 17:12:51 2012	(r303606)
@@ -7,6 +7,7 @@
 
 PORTNAME=	gpsd
 PORTVERSION=	3.6
+PORTREVISION=	1
 CATEGORIES=	astro geography
 MASTER_SITES=	SAVANNAH
 
@@ -191,6 +192,10 @@ SCONS_ARGS+=	ntpshm=no
 
 .if defined(WITHOUT_PPS)
 SCONS_ARGS+=	pps=no
+.else
+.	if defined(WITHOUT_NTPSHM)
+IGNORE=		PPS requires NTPSHM
+.	endif
 .endif
 
 .if defined(WITH_PPSONCTS)
@@ -268,6 +273,9 @@ PLIST_SUB+=	CURSES=""
 SCONS_ARGS+=	profiling=yes
 .endif
 
+post-patch:
+	@${REINPLACE_CMD} -e 's|-lpthread|${PTHREAD_LIBS}|g' ${WRKSRC}/Qgpsmm.pc.in
+
 # generates .py[co] files for installed modules
 # if that's not done, ${PYTHON_SITELIBDIR}/gps will be polluted
 # with these files when module is imported from root user
_______________________________________________
svn-ports-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-ports-all
To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org"
Comment 4 Dmitry Marakasov freebsd_committer freebsd_triage 2012-09-03 18:13:15 UTC
State Changed
From-To: open->closed

Committed. Thanks!